fix(input): preserve aux gamepad data and bump libvirtualhid - #5531
Merged
Conversation
Bundle ReportBundle size has no change ✅ |
ReenigneArcher
force-pushed
the
chore/test
branch
from
August 20, 2026 00:24
20866ba to
e5183d0
Compare
Screenshot ComparisonPR #5531 screenshots vs Matrix:
|
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-AMD64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: Windows-ARM64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
|
sunshine_tray_menu.png |
 |
|
sunshine_tray_pairing_request.png |
 |
|
sunshine_tray_paused.png |
 |
|
sunshine_tray_stopped.png |
 |
|
sunshine_tray_streaming.png |
 |
|
sunshine_tray_tooltip.png |
 |
Matrix: macOS-arm64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
Matrix: macOS-x86_64
| Image | Baseline | PR |
|---|---|---|
sunshine_tray_initial.png |
 |
 |
sunshine_tray_menu.png |
 |
 |
sunshine_tray_pairing_request.png |
 |
 |
sunshine_tray_paused.png |
 |
 |
sunshine_tray_stopped.png |
 |
 |
sunshine_tray_streaming.png |
 |
 |
sunshine_tray_tooltip.png |
 |
 |
ReenigneArcher
changed the title
21 tasks
ReenigneArcher
force-pushed
the
chore/test
branch
from
August 20, 2026 01:00
e5183d0 to
311105f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5531 +/- ##
==========================================
+ Coverage 32.29% 32.45% +0.15%
==========================================
Files 102 104 +2
Lines 24423 24999 +576
Branches 10824 11077 +253
==========================================
+ Hits 7887 8113 +226
+ Misses 15592 14661 -931
- Partials 944 2225 +1281
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 58 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
ReenigneArcher
force-pushed
the
chore/test
branch
from
August 20, 2026 16:03
311105f to
e1bacb1
Compare
Avoid overwriting motion, battery, and touchpad fields when submitting regular gamepad control updates. `gamepad_update` now starts from the translated control state and carries forward cached acceleration, gyroscope, battery, and touch contacts before calling `set_state`. Added a unit test to verify these auxiliary values persist across control updates, and bumped the `libvirtualhid` submodule to the required revision.
ReenigneArcher
force-pushed
the
chore/test
branch
from
August 20, 2026 19:50
e1bacb1 to
377ed20
Compare
ReenigneArcher
changed the title
ReenigneArcher
marked this pull request as ready for review
August 20, 2026 19:51
|
10 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid overwriting motion, battery, and touchpad fields when submitting regular gamepad control updates.
gamepad_updatenow starts from the translated control state and carries forward cached acceleration, gyroscope, battery, and touch contacts before callingset_state. Added a unit test to verify these auxiliary values persist across control updates, and bumped thelibvirtualhidsubmodule to the required revision.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.