Repository navigation
Reuse one SOAP client per URL and stop turning off SSL verification - #161
Merged
Merged
Conversation
no_ssl_verification swapped requests.Session.merge_environment_settings for the whole process while a SNOTEL request ran, so a request on another thread could run with verification off. The AWDB endpoint now verifies (checked against the live WSDL), so the SNOTEL client no longer uses it. metloom.request_utils stays importable, but no_ssl_verification now raises a DeprecationWarning, ahead of its removal in a later release. Every request also built a new zeep client, which downloads and parses the WSDL: about 0.6 s, against 0.14 s for a metadata call. The client is now built once per URL and shared.
micah-prime
reviewed
Oct 29, 2026
micah-prime
reviewed
Oct 29, 2026
micah-prime
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no_ssl_verification swapped requests.Session.merge_environment_settings for the whole process while a SNOTEL request ran, so a request on another thread could run with verification off. The AWDB endpoint now verifies (checked against the live WSDL), so the SNOTEL client no longer uses it. metloom.request_utils stays importable, but no_ssl_verification now raises a DeprecationWarning, ahead of its removal in a later release.
Every request also built a new zeep client, which downloads and parses the WSDL: about 0.6 s, against 0.14 s for a metadata call. The client is now built once per URL and shared.