Conversation
Signed-off-by: sici17 <francescosiciliani624@gmail.com>
Documentation build overview
14 files changed ·
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5476 +/- ##
========================================
Coverage 93.87% 93.87%
========================================
Files 182 182
Lines 22522 22522
Branches 3206 3206
========================================
Hits 21143 21143
Misses 917 917
Partials 462 462 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Can you describe in your own words how you've been using AI tools here? |
orbeckst
left a comment
There was a problem hiding this comment.
Please also update the docs for frame to state explicitly that boolean fancy indexing is supported; add a versionchanged. Check if there are other places in the docs that may need to be updated.
Check the User Guide https://github.com/MDAnalysis/UserGuide/, too, and either make changes via PR or at least raise an issue. The User Guide needs to be kept update with important user-facing updates.
Please also describe briefly in your own words how AI tools were used and what tools you used.
Thank you!
I use ai like a personal mentor, I ask questions to understand the problem, locate the parts of code that matter, discuss possible solutions and documentation changes. I reviewed the changes, asked questions until I understood them, and made the final decisions myself. Since English is not my native language, I also used it to help express what is happening much better than I could ever do. My main goal is understanding how the code works and how to move inside such a big codebase. |
Signed-off-by: sici17 <francescosiciliani624@gmail.com>
|
@sici17 , please have any issues/PRs in the User Guide mention this PR ( |
Fixes #5472
Changes made in this Pull Request:
AnalysisBase._setup_computation_groups()to recognize both Pythonbooland NumPynp.bool_values. NumPy boolean masks are now converted to frame indices correctly.test_base.pyfor NumPy boolean masks both in serial and multiprocessing scenarios.CHANGELOGentry for the fix.LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: yes
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.