Skip to content

Fix Read the Docs build with modern setuptools - #128

Merged
behackl merged 1 commit into
ManimCommunity:v0from
behackl:fix/readthedocs-build
Aug 4, 2026
Merged

Fix Read the Docs build with modern setuptools#128
behackl merged 1 commit into
ManimCommunity:v0from
behackl:fix/readthedocs-build

Conversation

@behackl

@behackl behackl commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the removed pkg_resources API in the Sphinx configuration
  • read the installed ManimPango version through importlib.metadata

Read the Docs currently upgrades setuptools to 83, where pkg_resources is no longer available. This caused the configuration phase of build 33903390 to fail.

Testing

  • built the package in a fresh Python 3.11 environment with setuptools 83.0.0
  • successfully built the HTML documentation with Sphinx 9.0.4

@PhilippImhof PhilippImhof left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naveen521kk naveen521kk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@behackl

behackl commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

wow, you two are fast!

@PhilippImhof

Copy link
Copy Markdown
Member

I haven't been contributing for a long time, but was still following the project loosely, so it was a pleasure to get that GitHub message :-) And a pleasure to see that you are still fully engaged

@naveen521kk

Copy link
Copy Markdown
Member

Reviewed on my phone but didn't notice @PhilippImhof also approved it :)

@behackl

behackl commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Haha! I've been doing very little over the past 1-2 years I guess, but this summer I have some more time and would like to get some things seriously modernised.

Haven't dared to open a PR yet and still have some things to flesh out for it -- but there is a generous refactor of ManimPango in my pipeline as well. 👀 https://github.com/behackl/ManimPango/tree/rewrite-v2

@behackl
behackl merged commit c550802 into ManimCommunity:v0 Aug 4, 2026
29 checks passed
@behackl
behackl deleted the fix/readthedocs-build branch August 4, 2026 08:28
@naveen521kk

Copy link
Copy Markdown
Member

Let me know once it's ready, I can spend sometime reviewing it. This repo didn't have much changes over the past few years other than KTLO, so it'll be a good refactor.

@behackl

behackl commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Will do! (And probably quite soon... :-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants