Repository navigation
Changed the default of BaseTesterSettings._env to {} - #14
Merged
Merged
Conversation
With a `None` default, `msgspec.to_builtins` writes `"_env": null` for a
tester whose environment has not been created yet, which callers then have to
special-case before using it as a mapping. msgspec copies an empty `{}`
default for each instance, so no explicit factory is needed. `None` is no
longer accepted: `_env` is set only by the autotester itself, never by
submitted settings.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
david-yz-liu
added a commit
to MarkUsProject/markus-autotesting
that referenced
this pull request
Oct 18, 2026
`_env` now defaults to `{}` in markus-autotesting-core
(MarkUsProject/markus-autotesting-core#14), so stored settings no longer
contain `"_env": null` and the fallback is unnecessary.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
BaseTesterSettings._envfromdict[str, Any] | None = Nonetodict[str, Any] = {}.The actual generated JSON schema is unchanged as
markus-autotesting'sgenerate_schemaremoves_envfrom the tester schemas.🤖 Generated with Claude Code