Skip to content

<fix>[kvm]: ZSV-9753 disable ip6tables without skipping IPv6#4605

Open
ZStack-Robot wants to merge 1 commit into
zsv_5.1.0from
sync/zstackio/codex/ZSV-9753-disable-ip6tables-zsv-5.1.0
Open

<fix>[kvm]: ZSV-9753 disable ip6tables without skipping IPv6#4605
ZStack-Robot wants to merge 1 commit into
zsv_5.1.0from
sync/zstackio/codex/ZSV-9753-disable-ip6tables-zsv-5.1.0

Conversation

@ZStack-Robot

Copy link
Copy Markdown
Collaborator

Summary

Backport the existing ZSTAC-71202/ZSTAC-71288 fix for ZSV-9753. Split the old skip.ipv6 behavior from ip6tables disabling by introducing bridge.disable.ip6tables and sending disableIp6Tables to kvmagent.

Changes

  • Add bridge.disable.ip6tables global property.
  • Pass disableIp6Tables during KVM host deploy and security-group cleanup/default-rule commands.
  • Update the related regression assertion to check disableIp6Tables.

Testing

  • git diff --check
  • CI pipeline
  • Manual test

Resolves: ZSV-9753

sync from gitlab !10577

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 22b9a3b1-3c7e-4896-86a9-13e4da043750

📥 Commits

Reviewing files that changed from the base of the PR and between a2e49c8 and 9b11f3a.

📒 Files selected for processing (6)
  • network/src/main/java/org/zstack/network/l3/NetworkGlobalProperty.java
  • plugin/kvm/src/main/java/org/zstack/kvm/KVMAgentCommands.java
  • plugin/kvm/src/main/java/org/zstack/kvm/KVMHost.java
  • plugin/kvm/src/main/java/org/zstack/kvm/KVMHostDeployArguments.java
  • plugin/kvm/src/main/java/org/zstack/kvm/KVMSecurityGroupBackend.java
  • test/src/test/groovy/org/zstack/test/integration/kvm/nic/MigrateVmSetDefaultRuleCase.groovy
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/zstackio/codex/ZSV-9753-disable-ip6tables-zsv-5.1.0

Comment @coderabbitai help to get the list of available commands.

@MatheMatrix
MatheMatrix force-pushed the sync/zstackio/codex/ZSV-9753-disable-ip6tables-zsv-5.1.0 branch 2 times, most recently from ce66aa5 to 830806e Compare July 17, 2026 08:29
GlobalPropertyImpact

Resolves: ZSV-9753

Change-Id: I71626269747462746d766f6b66697678696a726a
@MatheMatrix
MatheMatrix force-pushed the sync/zstackio/codex/ZSV-9753-disable-ip6tables-zsv-5.1.0 branch from 830806e to 9b11f3a Compare July 17, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant