always return true #32

Activity

1. MattKetmo commented on Oct 6, 2016

   

   MattKetmo

   on Oct 6, 2016

   Owner

   More actions

   /ping @olsgreen ;)
2. olsgreen commented on Oct 6, 2016

   

   olsgreen

   on Oct 6, 2016

   Contributor

   More actions

   @Grald Are you using the validator or trying to use it via DI or a facade?
3. josephsong commented on Apr 21, 2017

   

   josephsong

   on Apr 21, 2017

   More actions

   I'm seeing this, too, in Laravel. I've tried using it via DI and by plain instantiation (new EmailChecker).
4. olsgreen commented on Apr 21, 2017

   

   olsgreen

   on Apr 21, 2017

   Contributor

   More actions

   @josephsong Which version of Laravel are you using?
5. josephsong commented on Apr 21, 2017

   

   josephsong

   on Apr 21, 2017

   More actions

   Actually, Lumen v5.3.3.
6. josephsong commented on Apr 21, 2017

   

   josephsong

   on Apr 21, 2017

   More actions

   Well, it is funny. If I use yopmail.com as the domain for the test email, it does return false on the isValid call. But for any others I've tried from the list in this package, it still returns true.
7. josephsong commented on Apr 21, 2017

   

   josephsong

   on Apr 21, 2017

   More actions

   It seems that any of the domains in tests/EmailChecker/Tests/Adpater/BuiltInAdapterTest.php do come back as false. But any others in res/throwaway_domains.txt come back as true.

   I had just successfully implemented this package in WordPress, and all domains in the throwaway_domain.txt are marked as invalid. Seems to be something specific to Laravel/Lumen.