Add audit logs - #647
Open
varmar05 wants to merge 8 commits into
Open
Conversation
Introduce a pluggable audit module with NullSink default and emit() API. Wire SQLAlchemy listeners for user and project lifecycle events, explicit emits for auth and sync endpoints (login, password, access grants/revocations, version push, soft/hard delete, restore). Add actor_context()/request_context() helpers, device_id capture, scope_id for workspace-scoped filtering, and target_type auto-derivation. This is groundwork for adding more events and to be extended in EE with custom sinks, query API, and retention policy. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Coverage Report for CI Build 30524900752Coverage increased (+0.3%) to 92.496%Details
Uncovered Changes
Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Implements structured audit event emission for all relevant user and project actions. Update AuditEvent dataclass with new target columns: project_id, workspace_id and user_id. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…events Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Also simplify test_get_projects_by_uuids to avoid the fake-workspace-id hack. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
varmar05
marked this pull request as ready for review
July 30, 2026 07:25
varmar05
requested review from
MarcelGeo and
harminius
and removed request for
MarcelGeo
July 30, 2026 07:25
… events Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
harminius
approved these changes
Jul 30, 2026
| .with_entities(User.id, User.email) | ||
| .first() | ||
| ) | ||
| return (found.email, found.id) if found else (None, None) |
Contributor
There was a problem hiding this comment.
how about return ... else (login_str, None) to know at least something?
| ) | ||
| return "", 200 | ||
| else: | ||
| abort(403, "You do not have permissions") |
Contributor
There was a problem hiding this comment.
we don't want to log this?
we do log login fail..
Comment on lines
+581
to
+596
|
|
||
| if old_active and not user.active: | ||
| emit( | ||
| AuthEventType.USER_DEACTIVATED, | ||
| **actor_context(), | ||
| user_id=user.id, | ||
| target_email=user.email, | ||
| ) | ||
| elif not old_active and user.active: | ||
| emit( | ||
| AuthEventType.USER_RESTORED, | ||
| **actor_context(), | ||
| user_id=user.id, | ||
| target_email=user.email, | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
we don't log superadmin assignment?
| db.session.add(user) | ||
| db.session.commit() | ||
|
|
||
| if old_active and not user.active: |
Contributor
There was a problem hiding this comment.
should we re-querry the user?
Comment on lines
+603
to
+608
| emit( | ||
| AuthEventType.USER_MARKED_FOR_DELETION, | ||
| **actor_context(), | ||
| user_id=user.id, | ||
| target_email=user.email, | ||
| ) |
Contributor
There was a problem hiding this comment.
shall we emit after the action?
| **actor_context(), | ||
| project_id=project.id, | ||
| workspace_id=project.workspace_id, | ||
| target_email=requester.email if requester else None, |
Contributor
There was a problem hiding this comment.
we should get the actor email when they are authenticated, no?
(applies also for the following emits)
| project_id=project.id, | ||
| workspace_id=project.workspace_id, | ||
| target_email=requester.email if requester else None, | ||
| role=permission, |
Contributor
There was a problem hiding this comment.
the project name could be useful here
Comment on lines
296
to
+297
| project.delete() | ||
| db.session.info.pop("audit_skip_project_update", None) |
Contributor
There was a problem hiding this comment.
it would be safer to put his in try: and finally: to avoid stale info message, but that's rather a theoretical risk
| project_id=project.id, | ||
| workspace_id=project.workspace_id, | ||
| target_email=user.email if user else None, | ||
| role=removed_role.value, |
| project_id=p.id, | ||
| workspace_id=p.workspace_id, | ||
| project_name=f"{p.workspace.name}/{p.name}", | ||
| ) |
Contributor
There was a problem hiding this comment.
could we add info it was done by this celery task?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a pluggable audit module with NullSink default and emit() API.
Wire SQLAlchemy listeners for user and project lifecycle events, explicit emits for auth and sync endpoints (login, password, access grants/revocations, version push, soft/hard delete, restore).
Add actor_context()/request_context() helpers, device_id capture, scope_id for workspace-scoped filtering, and target_type auto-derivation.