Skip to content

fix(GUIMove): restrict Inventory mode to container screens and respect skip() for key suppression - #6726

Merged
MineGame159 merged 2 commits into
MeteorDevelopment:masterfrom
Eccys:fix/guimove-inventory-screens
Oct 17, 2026
Merged

MineGame159 merged 2 commits into
MeteorDevelopment:masterfrom
Eccys:fix/guimove-inventory-screens

Conversation

@Eccys

@Eccys Eccys commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Type of change

  • Bug fix
  • New feature

Description

  1. In GUIMove.skip(), Screens.Inventory previously only skipped WidgetScreen (along with the hardcoded text-input screens), allowing movement and rotation in non-inventory screens such as PauseScreen (the Escape menu), AdvancementsScreen, BookEditScreen, and HangingSignEditScreen. Updated skip() so Screens.Inventory requires AbstractContainerScreen<?>, Screens.Both requires WidgetScreen || AbstractContainerScreen<?>, and SignEditScreen is broadened to AbstractSignEditScreen.
  2. Added && !skip() to disableSpace() and disableArrows() so ScreenMixin.onKeyPressed does not swallow Space or Arrow keys in skipped screens (such as AnvilScreen, the Creative search tab, sign/book edit screens, or WidgetScreen when guis is set to Inventory).

Related issues

Fixes #5984

How Has This Been Tested?

Verified compilation against Minecraft 26.2 (./gradlew compileJava) and tested skip(), disableSpace(), and disableArrows() across GUI, Inventory, and Both modes.

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@MineGame159
MineGame159 merged commit 66eb651 into MeteorDevelopment:master Oct 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GUI move Guis: Inventory setting does not work

2 participants