Repository navigation
fix(GUIMove): restrict Inventory mode to container screens and respect skip() for key suppression - #6726
Merged
MineGame159 merged 2 commits intoOct 17, 2026
Conversation
…t skip() for key suppression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
GUIMove.skip(),Screens.Inventorypreviously only skippedWidgetScreen(along with the hardcoded text-input screens), allowing movement and rotation in non-inventory screens such asPauseScreen(the Escape menu),AdvancementsScreen,BookEditScreen, andHangingSignEditScreen. Updatedskip()soScreens.InventoryrequiresAbstractContainerScreen<?>,Screens.BothrequiresWidgetScreen || AbstractContainerScreen<?>, andSignEditScreenis broadened toAbstractSignEditScreen.&& !skip()todisableSpace()anddisableArrows()soScreenMixin.onKeyPresseddoes not swallow Space or Arrow keys in skipped screens (such asAnvilScreen, the Creative search tab, sign/book edit screens, orWidgetScreenwhenguisis set toInventory).Related issues
Fixes #5984
How Has This Been Tested?
Verified compilation against Minecraft 26.2 (
./gradlew compileJava) and testedskip(),disableSpace(), anddisableArrows()acrossGUI,Inventory, andBothmodes.Checklist: