test: direct unit suite for quantization core_utils (128 tests)#1904
Closed
arham766 wants to merge 1 commit into
Closed
test: direct unit suite for quantization core_utils (128 tests)#1904arham766 wants to merge 1 commit into
arham766 wants to merge 1 commit into
Conversation
Hermetic CPU-only unit tests; adversarially reviewed and verified to kill seeded mutations of the target module. Part of the coverage initiative in NVIDIA#1902. Signed-off-by: arham766 <arhamislam766@yahoo.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds a single new unit test module, ChangesCore utils test suite
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: new tests
Part of the unit-coverage initiative in #1902 (one PR per module; this one is self-contained). Covers: reduce_amax/reduce_sum/reduce_block_amax/reduce_block_padding numerics (hand-derived expectations incl. FP8 upcast, non-divisible assertions, content-preserving padding), quantizer attr-name helpers, quantized-module predicates, all CPU-testable context managers incl. exception-safety contracts, quantizer state dict round-trip, MoE expert amax sync math, NVFP4 static promotion, kv-cache config update non-mutation.
Usage
N/A — tests only.
Testing
Suite is hermetic (CPU-only, no network, deterministic, <3s) and passes locally; the full collectable tests/unit tree passes with it (1999 passed). The suite was adversarially reviewed and verified to kill seeded mutations of the target module (details in #1902).
Before your PR is "Ready for review"
Additional Information
Issue: #1902
Summary by CodeRabbit