Repository navigation
fix(executor): partition grouped global batches - #2645
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Contributor
|
sylvesterkaczmarek
force-pushed
the
fix-global-batch-partitioning-2643
branch
from
September 30, 2026 17:26
c74b10d to
b88acbf
Compare
Author
|
Refreshed this PR onto current upstream today. It is now 0 commits behind and mergeable, with the intended patch preserved and no unresolved review threads. This has been quiet for over two weeks. Could a maintainer please review/merge it, or let me know if anything else is needed? |
sylvesterkaczmarek
force-pushed
the
fix-global-batch-partitioning-2643
branch
2 times, most recently
from
September 30, 2026 17:40
b88acbf to
dd19873
Compare
Refreshed onto current upstream. Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
sylvesterkaczmarek
force-pushed
the
fix-global-batch-partitioning-2643
branch
from
October 1, 2026 07:59
dd19873 to
c83151f
Compare
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2643
Validation
python -m compileall -q nemo_retriever/src/nemo_retriever/graph/executor.py nemo_retriever/tests/test_global_batch_partitioning.pygit diff --check