Repository navigation
[None][feat] Attach feature and sparse metadata state as extensions #21194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yihwang-nv
wants to merge
9
commits into
NVIDIA:main
Choose a base branch
from
yihwang-nv:attention-metadata-extensions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13,419
−9,812
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ab81139
[None][feat] Attach feature and sparse metadata state as extensions
yihwang-nv 80322c1
[None][feat] Keep main's metadata spelling where the extensions allow it
yihwang-nv 6b3a611
[None][feat] Keep main's layout in the speculative workers and trim n…
yihwang-nv a0557f6
Merge remote-tracking branch 'origin/main' into attention-metadata-ex…
yihwang-nv 770e555
[None][fix] Fix dynamic-tree slot reads, fused MTP spec flag and MSA …
yihwang-nv 35a864f
Merge remote-tracking branch 'origin/main' into attention-metadata-ex…
yihwang-nv 2e3adc1
[None][feat] Fuse the GLM-5.2 draft-step length update into the model…
yihwang-nv 550a258
[None][feat] Declare a model's metadata extensions as its metadata_ex…
yihwang-nv 1133923
[None][chore] Fix stale metadata comments and restore a comment-only …
yihwang-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Required] The stock MTP-Eagle worker does not do this: it uses
self.draft_loop(attn_metadata)/self.refresh_draft()(eagle3.py:604, 1079;mtp.py:466, 990), theSpecWorkerBasewrappers that also install the draft as the model'sattention_metadataextra attribute (speculative/interface.py:3592-3605). MLA, DSA and KDA custom ops resolve their metadata from that extra attribute (attention.py:47-65), so a target that follows this README with stock MLA/DSA/KDA attention runs its draft forwards on the target metadata. Please point targets atSpecWorkerBase.draft_loop/refresh_draft, and also documentmetadata_extensionsand thelengths_for_kernel_update()rule for kernel-side length writes.