Repository navigation
Conversation
Signed-off-by: Tao Li <litaotju@users.noreply.github.com>
Signed-off-by: Tao Li <litaotju@users.noreply.github.com>
…guides Modeling V2 conventions are encouraged through docs and examples rather than enforced by tests. Keep only checks the code or CI depends on. - Docs: rewrite both Modeling V2 READMEs in plainer style, fix facts (resolver name, incremental rebuild of family libraries, build options), and describe target naming and family layout as conventions. - _native.py: find a target by its position in the package path rather than by "__" in its name. - modeling_v2.cmake: target names only need to be Python package names; family names may use uppercase; family torch namespaces join the collision check. - CBTS: select Modeling V2 tests per family from the changed path alone. - Tests: delete test_modeling_v2_claims.py and test_modeling_v2_native_claims.py. Keep the three checks per-family selection relies on in test_modeling_v2_ci_selection.py, and keep test_modeling_v2_native_loader.py to loader behavior. Signed-off-by: Tao Li <litaotju@users.noreply.github.com>
Signed-off-by: Tao Li <litaotju@users.noreply.github.com>
Draft
1 task done
Collaborator
|
Hi, heads-up: #22286 has merged, so ModelingV2 now lives at Since this PR touches modeling_v2, please rebase it onto the latest main. You can use these migration commands to move any files you added under the old directory and update any remaining references to the old path. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Draft smoke test of the TensorRT-LLM development workflow on an Omnistation and GB300: local edit, ARM64 source build targeting SM103, focused GPU validation, fork push, and draft PR creation.
This branch is based on #21376 at
66d808b2b2ec83439b225f8decc23a37d71d2d90, so the comparison tomainalso includes that parent PR's changes. The additional workflow change is limited to two files: an invalid native-loader package error now tells the caller to pass__name__from the target's__init__.py, and the existing assertion checks the hint.This is a draft workflow test. No reviewers are requested. GitHub currently reports conflicts against
main; this stacked draft is not ready to merge.Test Coverage
tests/unittest/_torch/modeling_v2/test_modeling_v2_native_loader.pytests/unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.pytests/unittest/_torch/modeling_v2/models/gpt_oss/gpt_oss_120b__sm_10x__default/test_modeling_v2_gpt_oss_swizzle_block_scales.pyThe build/test source inputs were the parent commit plus the two-file patch. The patch is byte-identical to the diff committed in
47003af897b974265b427101fa9061b2d6608b57(SHA-2562111bf414fa275b989377e979c4f5eda8893eefea9c5631dfd5f4b129a1ce645).PR Checklist