Repository navigation
[https://nvbugs/7028062][fix] Fix MiniMax test subprocess imports - #21671
Conversation
Signed-off-by: peihengh <259410613+peihu-nv@users.noreply.github.com>
|
/bot run --extra-stage "GB300-4_GPUs-PyTorch-Post-Merge-1,GB300-4_GPUs-PyTorch-Post-Merge-2,GR100-PyTorch-Post-Merge-1" |
|
PR_Github #82594 [ run ] triggered by Bot. Commit: |
Signed-off-by: peihengh <259410613+peihu-nv@users.noreply.github.com>
|
/bot run --disable-fail-fast --extra-stage "GB300-4_GPUs-PyTorch-Post-Merge-1,GB300-4_GPUs-PyTorch-Post-Merge-2,GR100-PyTorch-Post-Merge-1" |
|
PR_Github #82603 [ run ] triggered by Bot. Commit: |
|
PR_Github #82594 [ run ] completed with state |
|
PR_Github #82603 [ run ] completed with state
|
|
/bot run --disable-fail-fast --extra-stage "GB300-4_GPUs-PyTorch-Post-Merge-1,GB300-4_GPUs-PyTorch-Post-Merge-2,GR100-PyTorch-Post-Merge-1" |
|
PR_Github #82661 [ run ] triggered by Bot. Commit: |
|
PR_Github #82661 [ run ] completed with state
|
Signed-off-by: peihengh <259410613+peihu-nv@users.noreply.github.com>
|
/bot run --disable-fail-fast --extra-stage "GB300-4_GPUs-PyTorch-Post-Merge-1,GB300-4_GPUs-PyTorch-Post-Merge-2,GR100-PyTorch-Post-Merge-1" |
|
PR_Github #82978 [ run ] triggered by Bot. Commit: |
Signed-off-by: peihengh <259410613+peihu-nv@users.noreply.github.com>
|
/bot run --disable-fail-fast --extra-stage "GB300-4_GPUs-PyTorch-Post-Merge-1,GB300-4_GPUs-PyTorch-Post-Merge-2,GR100-PyTorch-Post-Merge-1" |
|
PR_Github #83056 [ run ] triggered by Bot. Commit: |
|
PR_Github #82978 [ run ] completed with state
|
|
PR_Github #83056 [ run ] completed with state
|
|
No actionable comments were generated in the recent review. WalkthroughRank subprocesses now match their ChangesMiniMax M3 test execution
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk:
|
sunnyqgg
left a comment
There was a problem hiding this comment.
Review of db02509: 0 blockers, 1 possibly blocking, 0 required, 4 nice to have. The import fix is correct for CI's layout (an unbuilt checkout at /tmp/TensorRT-LLM/src next to an installed wheel). It uses the same check #20814 put into the shared modeling_v2/comm/_rank_job.py, so pytest resolves the wheel and the ranks stop importing the source tree: that tree is where the No module named 'tensorrt_llm.bindings' failures in post-merge 3048/3049/3051 came from. All five stale copies are fixed. Dropping the nvbug 7027434 env-scope waive is also fine. #20623 is in the base and the scope check passes for test_minimax_m3.py. The file-level 7024242 waive still has to stay, because test_glm_moe_dsa.py:117 fails the same check. The only failure in L0 #68611 is the unrelated TestNanoV3Omni::test_auto_dtype[fp8_mmmu_encoder_cuda_graph] accuracy case, which passed in #68535. The open item is a GB300 run of the un-waived cases (see the comment on waives.txt).
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
/bot run --disable-fail-fast --extra-stage "GB300-4_GPUs-PyTorch-Post-Merge-1,GB300-4_GPUs-PyTorch-Post-Merge-2,GR100-PyTorch-Post-Merge-1" |
|
PR_Github #83143 [ run ] triggered by Bot. Commit: |
|
PR_Github #83143 [ run ] completed with state |
Dev Engineer Review
The five MiniMax
_rank_job.pyvariants now align rank-subprocess package lookup with the package resolved by pytest. They add the repository root toPYTHONPATHfor a missing or checkout-resolved package, and remove entries pointing to the repository root when pytest resolves an external package. The variants retain similar behavior, with small differences in added-line counts.The
waives.txtchanges remove six MiniMax SM103 TP4/TP8 communication-test waivers and a MiniMax environment-scope waiver. This enables those entries to run when selected; it does not establish that they passed. A broader modeling-v2 environment-scope waiver remains. No changed public API is reported. Current-head CI and test results are not available.QA Engineer Review
tests/integration/test_lists/waives.txtwas modified. It removes six communication-test skip entries and thetest_accuracy_engines_are_inside_environment_scopes[test_minimax_m3.py]skip entry. The GB300 multi-GPU test list still includes the TP4 and TP8 communication directories. The source changes update subprocess package selection but add no test functions or test IDs. Coverage verdict: needs follow-up, because the configured test selection is present but execution results are not available.Per-File QA Perspective
tests/integration/test_lists/waives.txt— Removes the six MiniMax communication-test skips and one environment-scope skip. The communication tests remain selected bytests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml; no test execution result is established.tests/unittest/_torch/modeling_v2/models/minimax_m3/minimax_m3_nvfp4__sm_103__tp4/comm/_rank_job.py— Rank subprocesses now follow pytest’s checkout-versus-installed package resolution. Verify bothPYTHONPATHbranches and the missing-package error path.tests/unittest/_torch/modeling_v2/models/minimax_m3/minimax_m3_nvfp4__sm_103__tp8/comm/_rank_job.py— Applies the same package-selection behavior for TP8 rank subprocesses. Verify the repository path is removed only when pytest resolves an external package.tests/unittest/_torch/modeling_v2/models/minimax_m3/minimax_m3_nvfp4__sm_107__tp2/comm/_rank_job.py— Applies the package-selection behavior to the SM107 TP2 subprocess. Verify source-checkout and external-install scenarios.tests/unittest/_torch/modeling_v2/models/minimax_m3/minimax_m3_nvfp4__sm_107__tp4/comm/_rank_job.py— Applies the package-selection behavior to the SM107 TP4 subprocess. Verify source-checkout and external-install scenarios.tests/unittest/_torch/modeling_v2/models/minimax_m3/minimax_m3_nvfp4__sm_107__tp8/comm/_rank_job.py— Applies the package-selection behavior to the SM107 TP8 subprocess. Verify source-checkout and external-install scenarios.Description
MiniMax collective test ranks can import an unbuilt checkout instead of the installed wheel, causing imports to fail before the tests run. Preserve the parent interpreter’s package selection for the rank subprocesses.
Remove the MiniMax-specific environment-scope waiver, whose underlying fix is already on main. The existing file-level waiver remains, so the scope-test file is still skipped by CI.
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.