Skip to content

[https://nvbugs/7082290][test] Unwaive the Modeling V2 CI selection checks fixed by #22085 - #22215

Merged
erictsai-nv merged 1 commit into
NVIDIA:mainfrom
erictsai-nv:unwaive-mv2-ci-selection
Nov 13, 2026
Merged

erictsai-nv merged 1 commit into
NVIDIA:mainfrom
erictsai-nv:unwaive-mv2-ci-selection

Conversation

@erictsai-nv

@erictsai-nv erictsai-nv commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Description

This PR removes two waivers from tests/integration/test_lists/waives.txt:

#22085 fixed both checks. The auto-waive PRs #22128 and #22129 merged after that fix.

Test Coverage

tests/unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.py passes on this branch (9 tests).

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Dev Engineer Review

No material findings. The change removes two waiver entries from a test-list file. It does not change source code, configuration, or test logic.

The diff matches the PR objectives. Only tests/integration/test_lists/waives.txt changed, with 0 lines added and 2 removed.

Risk: the two tests now run in CPU CI. Their pass status on this branch is reported by the author (9 tests pass in test_modeling_v2_ci_selection.py). This review did not run them, so the pass result is not independently confirmed.

QA Engineer Review

Test-list files changed:

  • tests/integration/test_lists/waives.txt: removed 2 entries.
    • full:CPU/unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.py::test_every_test_is_in_a_test_list SKIP (https://nvbugs/7082290)
    • full:CPU/unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.py::test_unit_test_directories_mirror_source SKIP (https://nvbugs/7082289)

Test functions, test files, and test-db or qa list entries: unchanged.

Behavior covered: the two checks are unwaived. They verify that every test is in a test list and that unit-test directories mirror source. The author reports both pass after the fix in #22085. Auto-waive PRs #22128 and #22129 merged after that fix.

Verification to perform: run tests/unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.py in the CPU CI stage. Confirm all 9 tests pass, including the two unwaived checks.

Coverage verdict: needs follow-up. The diff is a valid unwaive, but the pass result is author-reported and not confirmed by a completed check on this head.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Removes two CPU waivers. QA should confirm the two test_modeling_v2_ci_selection.py checks pass in CPU CI.

…hecks fixed by NVIDIA#22085

Signed-off-by: Eric Tsai <ertsai@nvidia.com>
@erictsai-nv
erictsai-nv marked this pull request as ready for review November 13, 2026 03:11
@erictsai-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Two skip entries were removed from the CPU test list: test_every_test_is_in_a_test_list and test_unit_test_directories_mirror_source.

Changes

CPU test-list updates

Layer / File(s) Summary
Remove test skip entries
tests/integration/test_lists/waives.txt
Removes the skip entries for test_every_test_is_in_a_test_list and test_unit_test_directories_mirror_source.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: trtllm-agent

Merge Risk: Minimal · up to e8506

This change re-enables two Modeling V2 CI selection checks that were previously skipped. The checks are reported to pass on this branch, and no merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: removing two waivers so the Modeling V2 CI selection checks run again. It also cites the NVBugs ID and the fix PR #22085. It follows the [ID][type] Summary template, b…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description states that the PR removes two waivers from tests/integration/test_lists/waives.txt for test_every_test_is_in_a_test_list (nvbugs/7082290) and test_unit_test_directories_mirror_source …
Full details: Title check

Explanation

The title names the main change: removing two waivers so the Modeling V2 CI selection checks run again. It also cites the NVBugs ID and the fix PR #22085. It follows the [ID][type] Summary template, but the type tag is missing. Under the criteria, the title matches the change, so it passes.

Full details: Description check

Explanation

The description states that the PR removes two waivers from tests/integration/test_lists/waives.txt for test_every_test_is_in_a_test_list (nvbugs/7082290) and test_unit_test_directories_mirror_source (nvbugs/7082289). It says #22085 fixed both checks and that auto-waive PRs #22128 and #22129 merged afterward. It reports that tests/unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.py passes on the branch with 9 tests. The description covers what changed and why, and it includes a test coverage note. The template's Description and Test Coverage sections are present and filled in. The PR checklist is ticked, but the individual items were not verified. The template's title format and PR label requirements are not addressed in the description. These are minor gaps and do not block the check.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 3cee204 and e8506f9.

Files selected for processing: 1

  • tests/integration/test_lists/waives.txt
Files with no reviewable changes: 1

  • tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #84655 [ run ] triggered by Bot. Commit: e8506f9 Link to invocation

@sunnyqgg sunnyqgg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 0 Blockers, 0 Possible blockers, 0 Required, 0 Nice to have. Both waives are stale. #22085 (672e049, already on this PR's base) fixed the two failures they cite: the models/qwen4_exp/hc test directory with no source directory, and the accuracy targets listed only in the YAML QA list. The auto-waive PRs #22128 and #22129 were filed from failures that last occurred at 2026-11-11T16:55Z, before that fix merged. Both checks pass on this head: 9/9 locally, and in this PR's CI run (L0_MergeRequest_PR #70032: CPU-Generic-x86-1-cbts and CPU-Generic-arm-1-cbts each ran 9 tests, 0 failures, 0 skipped). No other waives.txt entry or skip marker references these tests or bugs, and main's newer waives.txt edits don't conflict with these lines. After merge, nvbugs/7082290 and nvbugs/7082289 both lose their last waive and can be closed.

@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #84655 [ run ] completed with state SUCCESS. Commit: e8506f9
/LLM/main/L0_MergeRequest_PR pipeline #70032 completed with status: 'SUCCESS'

CI Report

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants