Repository navigation
[https://nvbugs/7082290][test] Unwaive the Modeling V2 CI selection checks fixed by #22085 - #22215
Conversation
…hecks fixed by NVIDIA#22085 Signed-off-by: Eric Tsai <ertsai@nvidia.com>
|
/bot run |
|
No actionable comments were generated in the recent review. WalkthroughTwo skip entries were removed from the CPU test list: ChangesCPU test-list updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Suggested reviewers: Merge Risk:
|
|
PR_Github #84655 [ run ] triggered by Bot. Commit: |
sunnyqgg
left a comment
There was a problem hiding this comment.
LGTM. 0 Blockers, 0 Possible blockers, 0 Required, 0 Nice to have. Both waives are stale. #22085 (672e049, already on this PR's base) fixed the two failures they cite: the models/qwen4_exp/hc test directory with no source directory, and the accuracy targets listed only in the YAML QA list. The auto-waive PRs #22128 and #22129 were filed from failures that last occurred at 2026-11-11T16:55Z, before that fix merged. Both checks pass on this head: 9/9 locally, and in this PR's CI run (L0_MergeRequest_PR #70032: CPU-Generic-x86-1-cbts and CPU-Generic-arm-1-cbts each ran 9 tests, 0 failures, 0 skipped). No other waives.txt entry or skip marker references these tests or bugs, and main's newer waives.txt edits don't conflict with these lines. After merge, nvbugs/7082290 and nvbugs/7082289 both lose their last waive and can be closed.
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
PR_Github #84655 [ run ] completed with state |
Description
This PR removes two waivers from
tests/integration/test_lists/waives.txt:test_modeling_v2_ci_selection.py::test_every_test_is_in_a_test_list(https://nvbugs/7082290)test_modeling_v2_ci_selection.py::test_unit_test_directories_mirror_source(https://nvbugs/7082289)#22085 fixed both checks. The auto-waive PRs #22128 and #22129 merged after that fix.
Test Coverage
tests/unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.pypasses on this branch (9 tests).PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Dev Engineer Review
No material findings. The change removes two waiver entries from a test-list file. It does not change source code, configuration, or test logic.
The diff matches the PR objectives. Only
tests/integration/test_lists/waives.txtchanged, with 0 lines added and 2 removed.Risk: the two tests now run in CPU CI. Their pass status on this branch is reported by the author (9 tests pass in
test_modeling_v2_ci_selection.py). This review did not run them, so the pass result is not independently confirmed.QA Engineer Review
Test-list files changed:
tests/integration/test_lists/waives.txt: removed 2 entries.full:CPU/unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.py::test_every_test_is_in_a_test_list SKIP (https://nvbugs/7082290)full:CPU/unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.py::test_unit_test_directories_mirror_source SKIP (https://nvbugs/7082289)Test functions, test files, and test-db or qa list entries: unchanged.
Behavior covered: the two checks are unwaived. They verify that every test is in a test list and that unit-test directories mirror source. The author reports both pass after the fix in
#22085. Auto-waive PRs#22128and#22129merged after that fix.Verification to perform: run
tests/unittest/_torch/modeling_v2/test_modeling_v2_ci_selection.pyin the CPU CI stage. Confirm all 9 tests pass, including the two unwaived checks.Coverage verdict:
needs follow-up. The diff is a valid unwaive, but the pass result is author-reported and not confirmed by a completed check on this head.Per-File QA Perspective
tests/integration/test_lists/waives.txt: Removes two CPU waivers. QA should confirm the twotest_modeling_v2_ci_selection.pychecks pass in CPU CI.