You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Coverage follow-up to #21621, merged as 5007a5be99e8.
The product FP8 routing fix is already on main; this change restores coverage
without duplicating that code.
Remove only the https://nvbugs/7088470 waiver for accuracy/test_llm_api_pytorch.py::TestQwen3_8_Flash_Next::test_fp8_adp4_mtp3_prefix_cache.
The existing case is registered in tests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml.
All other waiver entries remain unchanged.
The sibling test_fp8_adp4_mtp3_trtllm_ple_offload waiver
(https://nvbugs/7078608) is intentionally unchanged. The verification below
does not include that case or establish that its reported pre-merge worker exit
was caused by the routing assertion. This PR does not claim to fix that separate
failure.
Verified with the waiver removal applied to main snapshot a8b2da508369:
The 17 executed predecessor cases from the affected CI shard, followed by accuracy/test_llm_api_pytorch.py::TestQwen3_8_Flash_Next::test_fp8_adp4_mtp3_prefix_cache, run together in one pytest process: 18 passed, no skips, on four GB300 GPUs, using the source waiver file with only this entry removed.
CPU-marked routing/layout tests in tests/unittest/_torch/modeling_v2/models/qwen4_exp/qwen3_8_flash_next_nvfp4__sm_103__default/test_routing.py and tests/unittest/_torch/modeling_v2/models/qwen4_exp/qwen3_8_flash_next_fp8__sm_103__unified/test_routing_and_layout.py: 276 passed, no skips; 35 non-CPU cases deselected.
The existing accuracy test covers the restored entry. No test assertions, references, or product code change; no new code paths are introduced.
PR Checklist
Reviewed the applicable checklist items for this waiver-only change.
Dev Engineer Review
The diff removes one line from tests/integration/test_lists/waives.txt. The removed entry is the SKIP waiver for accuracy/test_llm_api_pytorch.py::TestQwen3_8_Flash_Next::test_fp8_adp4_mtp3_prefix_cache (NVBug 7088470).
No source code changes. No test code changes. Other waiver entries are unchanged.
Risk: the test runs again in CI on GB300 after this change. The PR reports 18 passed, no skips, on four GB300 GPUs, with the waiver removed. These results come from the author. This review did not run the tests, and no CI results for this head were available.
The product fix that the test depends on is stated as merged in #21621. This PR does not change that code.
QA Engineer Review
Test files and test-list files changed:
Modified: tests/integration/test_lists/waives.txt (1 line removed).
The restored case covers FP8 routing with ADP4, MTP3, and prefix cache on Qwen3-8 Flash Next.
The PR reports these results, with the waiver removed:
18 passed, no skips, in one pytest process on four GB300 GPUs. This covers 17 predecessor cases and the restored case.
276 passed, no skips, for the CPU-marked routing and layout tests under tests/unittest/_torch/modeling_v2/models/qwen4_exp/. 35 non-CPU cases were deselected.
The test remains registered in tests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml.
Coverage verdict: needs follow-up. The author-reported results pass, but no CI run on the current head was available to confirm them.
Per-File QA Perspective
tests/integration/test_lists/waives.txt: The restored case now runs in the GB300 multi-GPU job. QA should confirm that the case passes in CI before the waiver is considered closed.
Remove the waiver for
accuracy/test_llm_api_pytorch.py::TestQwen3_8_Flash_Next::test_fp8_adp4_mtp3_prefix_cache
after the block-FP8 route landed in NVIDIA#21621 (5007a5b).
The case remains registered in
tests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml.
Keep the other entries in tests/integration/test_lists/waives.txt unchanged.
Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
This change re-enables one previously waived Qwen3 accuracy test after the underlying routing fix was merged. It touches no product code, and no actionable merge-blocking risk remains.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title uses the NVBugs ID and [fix] type in the template format. It names the restored FP8 prefix-cache accuracy coverage, which matches the sole change: removal of the waiver for test_fp8_adp4_mtp…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description states the purpose: removing only the https://nvbugs/7088470 waiver for test_fp8_adp4_mtp3_prefix_cache, which restores coverage after the FP8 routing fix in #21621. It explains that t…
Full details: Title check
Explanation
The title uses the NVBugs ID and [fix] type in the template format. It names the restored FP8 prefix-cache accuracy coverage, which matches the sole change: removal of the waiver for test_fp8_adp4_mtp3_prefix_cache in waives.txt. It is a bit broader than the one-line waiver removal, but it reflects the main change.
Full details: Description check
Explanation
The description states the purpose: removing only the https://nvbugs/7088470 waiver for test_fp8_adp4_mtp3_prefix_cache, which restores coverage after the FP8 routing fix in #21621. It explains that the sibling waiver (nvbugs/7078608) is intentionally unchanged, and it gives concrete test results (18 passed on four GB300 GPUs; 276 CPU routing/layout tests passed). It also includes a Fixes link and a checklist item. The template's Description and Test Coverage sections are present and substantive. The PR title and the template's PR Checklist items are not addressed beyond one checkbox, so the author should confirm the title format follows the NVBugs pattern and that the checklist items apply.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between eafebd8 and 8d2bcf7.
Files selected for processing: 1
tests/integration/test_lists/waives.txt
Files with no reviewable changes: 1
tests/integration/test_lists/waives.txt
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Checked the un-waive against nvbugs/7088470 and the fix it depends on, #21621 (5007a5b), which is on the base. The failure came from FP8_BLOCK_SCALES checkpoints being auto-routed to the NVFP4 modeling_v2 target on SM103. #21621 now sends them to the FP8 target, and that target accepts this test's dep4 / MTP3 / block-reuse configuration. Posted: 0 blockers, 0 possible blockers, 1 nice to have (inline, on the sibling 7078608 waive).
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Coverage follow-up to #21621, merged as
5007a5be99e8.The product FP8 routing fix is already on main; this change restores coverage
without duplicating that code.
Remove only the
https://nvbugs/7088470waiver foraccuracy/test_llm_api_pytorch.py::TestQwen3_8_Flash_Next::test_fp8_adp4_mtp3_prefix_cache.The existing case is registered in
tests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml.All other waiver entries remain unchanged.
The sibling
test_fp8_adp4_mtp3_trtllm_ple_offloadwaiver(
https://nvbugs/7078608) is intentionally unchanged. The verification belowdoes not include that case or establish that its reported pre-merge worker exit
was caused by the routing assertion. This PR does not claim to fix that separate
failure.
Fixes https://nvbugs/7088470
Test Coverage
Verified with the waiver removal applied to main snapshot
a8b2da508369:accuracy/test_llm_api_pytorch.py::TestQwen3_8_Flash_Next::test_fp8_adp4_mtp3_prefix_cache, run together in one pytest process: 18 passed, no skips, on four GB300 GPUs, using the source waiver file with only this entry removed.tests/unittest/_torch/modeling_v2/models/qwen4_exp/qwen3_8_flash_next_nvfp4__sm_103__default/test_routing.pyandtests/unittest/_torch/modeling_v2/models/qwen4_exp/qwen3_8_flash_next_fp8__sm_103__unified/test_routing_and_layout.py: 276 passed, no skips; 35 non-CPU cases deselected.PR Checklist
Dev Engineer Review
tests/integration/test_lists/waives.txt. The removed entry is the SKIP waiver foraccuracy/test_llm_api_pytorch.py::TestQwen3_8_Flash_Next::test_fp8_adp4_mtp3_prefix_cache(NVBug 7088470).#21621. This PR does not change that code.QA Engineer Review
Test files and test-list files changed:
tests/integration/test_lists/waives.txt(1 line removed).Waivers removed:
accuracy/test_llm_api_pytorch.py::TestQwen3_8_Flash_Next::test_fp8_adp4_mtp3_prefix_cache SKIP (https://nvbugs/7088470)Behavior and coverage:
tests/unittest/_torch/modeling_v2/models/qwen4_exp/. 35 non-CPU cases were deselected.tests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml.Coverage verdict:
needs follow-up. The author-reported results pass, but no CI run on the current head was available to confirm them.Per-File QA Perspective
tests/integration/test_lists/waives.txt: The restored case now runs in the GB300 multi-GPU job. QA should confirm that the case passes in CI before the waiver is considered closed.