Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/integration/test_lists/waives.txt
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,8 @@ unittest/_torch/attention/multi_gpu --ignore=unittest/_torch/attention/multi_gpu
unittest/_torch/attention/multi_gpu/test_mla_helix_context.py::test_k3_mla_helix_owned_prefill[tp1-cp4-gate-fp8-weights-bf16-kv] SKIP (https://nvbugs/7109810)
unittest/_torch/attention/sparse/csa2/test_module.py::test_fused_native_index_q_and_graph SKIP (https://nvbugs/7039506)
unittest/_torch/misc/test_guided_decoder_errors.py::test_executor_loop_fails_the_request_once_its_batch_is_synchronized SKIP (https://nvbugs/7068781)
unittest/_torch/modeling_v2/models/kimi_k3_vl/kimi_k3_nvfp4__sm_107__helix8_moetp2ep4/test_helix8_moetp2ep4_constants.py::test_constants_are_the_reference_profile SKIP (https://nvbugs/7113413)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nice to have] (R2: Test lists and waives) These two lines clear only the kimi_k3_nvfp4__sm_107__helix8_moetp2ep4 entry. The same ImportError (cannot import name '_fp4_mla_generation_num_blocks_device', raised from kimi_k3_vl/ops/attention/_k3_fp4_mla_cache.py:60) stops the three sibling entries in l0_cpu.yml at collection: ...__sm_107__dep16 (169), ...__helix8_moeep8 (170) and ...__tp1 (172). Each of these directories has a test that imports its target's modeling at module level (test_dep16_k3_mla_ctx_split_k.py:14, test_helix8_k3_mla_ctx_split_k.py:14, tp1/test_k3_mla_ctx_split_k.py:20).

In L0_MergeRequest_PR #70923 (CPU-Generic-x86/arm shards 2-4), all three end with "Interrupted: 1 error during collection", so their copies of these two constants tests never run. Per-test lines can't fix that, because apply_waives_ut in tests/unittest/conftest.py only marks collected items. None of the other open auto-waive PRs covers these entries either. Until #22545 lands, the CPU stage stays red for the PRs the description asks to rebase or re-run.

If the waive route is kept, waive them as whole entries, in the same form as the existing full:sm100/unittest/bindings SKIP:

unittest/_torch/modeling_v2/models/kimi_k3_vl/kimi_k3_nvfp4__sm_107__dep16 SKIP (https://nvbugs/7113413)
unittest/_torch/modeling_v2/models/kimi_k3_vl/kimi_k3_nvfp4__sm_107__helix8_moeep8 SKIP (https://nvbugs/7113413)
unittest/_torch/modeling_v2/models/kimi_k3_vl/kimi_k3_nvfp4__sm_107__tp1 SKIP (https://nvbugs/7113413)

This also covers the same entries on the GR100 post-merge list (l0_gr100.yml:152-154).

unittest/_torch/modeling_v2/models/kimi_k3_vl/kimi_k3_nvfp4__sm_107__helix8_moetp2ep4/test_helix8_moetp2ep4_constants.py::test_target_class_declares_its_constants_and_no_model_defaults SKIP (https://nvbugs/7113413)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nice to have] (R1: PR process) The fix for this ImportError is already open as #22545. It defines _fp4_mla_generation_num_blocks_device in the K3 family's _k3_fp4_mla_cache.py, and its description lists the target constants tests among those it fixes. But #22545 cites none of the auto-waive bugs and removes no waives.txt line.

This PR is also one of ten open auto-waive PRs for the same ImportError, each with its own bug (#22523, #22524, #22525, #22536, #22539, #22542, #22543, #22544, #22548). Seven of them insert at this same spot, so each merge conflicts with the next.

If this merges first, nothing ties these lines to the fix, and the two tests stay skipped after #22545 lands. If #22545 merges first, this PR waives two passing tests. Please coordinate the merge order: close this PR (and its siblings) once #22545 lands, or have #22545 delete these lines and reference nvbugs/7113413 so the bug closes with the fix.

unittest/_torch/moe/test_dynamic_eplb_contracts.py::test_on_autotune_builds_balanced_powerlaw_input SKIP (https://nvbugs/7034332)
unittest/_torch/moe/test_moe_backend.py::test_fc1_prologue_wait_keeps_a_longer_stream_open SKIP (https://nvbugs/7099532)
unittest/_torch/moe/test_moe_backend.py::test_fc1_prologue_wait_preserves_exhaustion SKIP (https://nvbugs/7099532)
Expand Down
Loading