Repository navigation
[https://nvbugs/7113411][infra] Waive 1 failed case(s) on all platforms #22539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
trtllm-agent
wants to merge
1
commit into
NVIDIA:main
from
trtllm-agent:auto-waive/5461c95322af8a56ad1d8d1b0fb2ea28
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Nice to have] (R1: PR process) #22545 fixes this same failure. #22078 removed
_fp4_mla_generation_num_blocks_devicefromfp4_mla/metadata.py, #21996's Kimi K3 code still imports it (_k3_fp4_mla_cache.py:58,k3r_fp4_mla/fp4_mla_kv_append.py:46), and #22545 moves the helper into_k3_fp4_mla_cache.py. Eight sibling auto-waive PRs (#22523, #22524, #22525, #22534, #22536, #22542, #22543, #22544) waive other tests that fail with the same ImportError, each under its own NVBug. None of these PRs or bugs is linked to the fix. If #22545 lands first and this merges afterwards, the line skips a passing test, which is the only CI check that K3routing.routereturns the SM107 target class. The restore condition keys only on nvbugs/7113411, so nothing prompts removing the line.Suggest linking nvbugs/7113411 and the sibling bugs to #22545 and settling the merge order. If the fix lands first, close this PR. Otherwise, #22545 or the bug owner should delete this line together with the siblings' lines. Note that the PRs listed in the description need #22545 regardless, because the same ImportError aborts collection of three SM107 test directories, and no waive line can skip a collection error.