Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/integration/test_lists/waives.txt
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ full:B300/accuracy/test_kimi3.py::TestKimiK3::test_gsm8k_nvfp4_kv_dep8 SKIP (htt
full:B300/accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_w4_4gpus[v2_kv_cache-dp4-trtllm-auto] SKIP (https://nvbugs/7023202)
full:B300/disaggregated/test_disaggregated.py::test_disaggregated_mamba_conc_greater_than_mbs[NVIDIA-Nemotron-3-Super-120B-A12B-FP8] SKIP (https://nvbugs/7088440)
full:B300/disaggregated/test_disaggregated.py::test_disaggregated_qwen3_32b_fp8[Qwen3/Qwen3-32B-FP8] SKIP (https://nvbugs/7099626)
full:CPU/unittest/_torch/modeling_v2/models/kimi_k3_vl/ops/attention/test_modeling_v2_k3_fp4_mla_copies.py::test_copies_import_only_the_contract_from_the_backend[_k3_fp4_mla_cache] SKIP (https://nvbugs/7113610)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nice to have] (R2: Test lists and waives) For nvbugs/7113610, the cause and the fix are already known. #21996 made _k3_fp4_mla_cache.py:60 and kernels/k3r_fp4_mla/fp4_mla_kv_append.py:46 import _fp4_mla_generation_num_blocks_device, which #22078 had removed from fp4_mla/metadata.py. The open #22545 defines that helper in _k3_fp4_mla_cache.py. With its diff applied to this base, all 8 cases of test_modeling_v2_k3_fp4_mla_copies.py pass, this one included.

#22545 does not touch waives.txt, though, so this line and the fix race. If #22545 merges first, please close this PR rather than merge a waive for a passing test. Otherwise, please have #22545 (or the bug owner) delete this line, and the sibling lines from #22543/#22536, in the same change. Please also link #22545 in the bug, which is still unprioritized.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nice to have] (R1: PR process) This is one of three open auto-waive PRs for the same file and the same root cause. #22543 (nvbugs/7113609) waives test_copied_definitions_match_their_sources[_k3_fp4_mla_cache], and #22536 (nvbugs/7113412) waives test_copied_definitions_match_their_sources[_k3_fp4_mla_kernels]. Running the file on this tree gives exactly these three failures (3 failed, 5 passed), all from #21996 landing after #22078 changed the FP4 MLA backend.

Merged alone, this PR does not turn the CPU stages green. The PRs listed in the description still fail on the other two cases, and so does this PR's own CPU run, because change-based selection runs the whole file. All three PRs also insert after line 69, so whichever merges second conflicts at this line: git merge-file of this PR with #22543 conflicts here.

Please land the three together, either folded into one PR or merged back to back with a rebase. Please also mark nvbugs/7113609, 7113412 and 7113610 as one root cause, so a single fix closes all three.

full:CPU/unittest/scripts/test_subprocess_timeouts.py::test_every_subprocess_run_call_in_test_code_must_set_timeout SKIP (https://nvbugs/6929769)
full:DGX_B200/accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_bfloat16[mtp_nextn=2-attention_dp=True-cuda_graph=True-overlap_scheduler=True-torch_compile=False-enable_chunked_prefill=False-v2_kv_cache=True] SKIP (https://nvbugs/6633268)
full:DGX_B200/unittest/tools/test_layer_wise_benchmarks.py::test_performance_alignment[1] SKIP (https://nvbugs/6669275)
Expand Down
Loading