Repository navigation
[https://nvbugs/7113764][infra] Waive 20 failed case(s) on all platforms #22548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
trtllm-agent
wants to merge
1
commit into
NVIDIA:main
from
trtllm-agent:auto-waive/7afcd39eecdacbfddd7f7625b361722a
+20
−0
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Blocker] (B3: CI breakage)
test_context_and_decode_match_backend[fp8-op_b2_q1-128]is missing here, and it fails on DGX_B300 with the same ImportError. The test callsops = _ops()attest_modeling_v2_k3_mla_attn_ops.py:415, before its off-SM107pytest.skipat lines 419-425._ops()goes throughk3_mla_cache.py:40to_k3_fp4_mla_cache.py:58-64and raisesImportError: cannot import name '_fp4_mla_generation_num_blocks_device', so on SM103 this case errors out instead of skipping.In L0 #70898 (PR #22261), DGX_B300-PyTorch-3 reports this file as tests=22, failures=21, skipped=1, and
[fp8-op_b2_q1-128]is one of the 21. L0 #70869, #70899, #70903, #70904, #70907 and #70910 show the same result. With 20 of the 21 waived, DGX_B300-PyTorch-3 stays red for every PR (CI merges the TOT waive list into each run), so the 7 PRs listed in the description still fail when they re-run.Suggested fix: add the case at its sorted position, right above this line:
and say 21 cases in the title and description. Alternatively, replace the 20 lines with one file-level entry,
unittest/_torch/modeling_v2/models/kimi_k3_vl/ops/attention/test_modeling_v2_k3_mla_attn_ops.py SKIP (https://nvbugs/7113764). That works for three reasons:l0_b300.yml:221, the only list that runs this file, every case either fails with this ImportError or skips itself (test_nvfp4_generation_scatter_matches_backendis SM107-only);tests/unittest/conftest.py:346-361, precedent atwaives.txt:207-208);