Skip to content

[https://nvbugs/7117673][infra] Waive 1 failed case(s) on all platforms - #22589

Merged
karljang merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:auto-waive/5e8b0467591247108fba7787156ed633
Nov 19, 2026
Merged

karljang merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:auto-waive/5e8b0467591247108fba7787156ed633

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Temporarily waive 1 failed case(s) on all platforms with unscoped line(s): the failure is a code-level error that fails on every platform, first seen on CPU. Opened automatically by auto-waive (draft; a human reviews and merges).

The native main-break detector (native-p3/k3-w12h-fresh12h-nopass-hostclock/1.0.1) reports unittest/_torch/modeling_v2/models/kimi_k3_vl/common/test_k3_kda_metadata.py::test_inforward_split broken on main for CPU: failure signature importerror: cannot import name inforwardsnapshot...executor/kv_cache/mamba_cache_manager/__init__.py), onset 2026-11-18T12:46:42Z, latest failure 2026-11-18T21:06:39Z. Policy native_p3@1.0.0 selected it; https://nvbugs/7117673 tracks the fix. The line is unscoped: the failure is a code-level error that does not depend on the GPU (seen on CPU; stage prefix CPU), so every platform that runs the case fails it.

  • Bug: https://nvbugs/7117673 (details, logs and 7-day test history are in the bug)
  • Restore coverage when: Remove this line when https://nvbugs/7117673 is fixed or closed and the test passes post-merge; un-waive follows the bug, not the PR.
  • Scope reviewed by: auto-waive at 2026-11-18T23:06:12.075122+00:00

Tests in this break event:

  • unittest/_torch/modeling_v2/models/kimi_k3_vl/common/test_k3_kda_metadata.py::test_inforward_split on CPU

PRs whose pre-merge runs hit this break (rebase or re-run after this merges):

unittest/_torch/modeling_v2/models/kimi_k3_vl/common/test_k3_kda_metadata.py::test_inforward_split SKIP (https://nvbugs/7117673)

What to check before merging:

  • The bug's test-history links show the cases failing on main, not only on the trigger PR.
  • The scope all platforms matches the failing stage and no narrower waiver already exists.
  • Nothing else is needed from you after merging: the bug owner removes these lines with the fix.
Provenance
  • Detector native-p3/k3-w12h-fresh12h-nopass-hostclock/1.0.1, policy native_p3@1.0.0
  • Run 7a04645b-f857-4235-aa42-54fab1f16b4a; snapshot SHA-256 fbcf14b995774801d624cdf4e76a134bda94859c36e9af23010fc9934e5df7ca; config SHA-256 465a88e1b18cbe3245f999c7a82690481adb9fa9d03086d8e5e54ea20b3e7190
  • unittest/_torch/modeling_v2/models/kimi_k3_vl/common/test_k3_kda_metadata.py::test_inforward_split: incident aaebf4a8d015148f03b29732676fcf99ab35ad96f5e845e10cddeb50a77d527a, observation 3c27e767e29908fc643dab4e7f1b5cae8a6202a937fdd03e7b6d2d6f74741bc4

Test Coverage

Review the incident evidence and selector scope before merging. This proposal does not
establish that main is fixed. Confirm restoration separately after the corrective change.

PR Checklist

  • Please check this after reviewing the above items as appropriate for this PR.

Dev Engineer Review

  • The diff changes one file, tests/integration/test_lists/waives.txt, with one added line and no removed lines.
  • The added line waives unittest/_torch/modeling_v2/models/kimi_k3_vl/common/test_k3_kda_metadata.py::test_inforward_split as SKIP (https://nvbugs/7117673).
  • The waiver has no platform selector, so it applies to all platforms, as the PR objectives state.
  • No source code changes. The waiver hides the test result but does not fix the reported import error. Main remains unverified.
  • The objectives say to remove the waiver after the bug is fixed or closed. No removal condition is recorded in the file.

QA Engineer Review

  • Test-list file modified: tests/integration/test_lists/waives.txt. One entry added:
    • unittest/_torch/modeling_v2/models/kimi_k3_vl/common/test_k3_kda_metadata.py::test_inforward_split SKIP (https://nvbugs/7117673)
  • No test function code was changed.
  • Coverage impact: the test does not run on any platform while the waiver exists. The test covers Kimi K3 VL KDA metadata split behavior in forward. Its coverage is lost until NVBUG 7117673 is resolved.
  • Coverage verdict: needs follow-up. Restore coverage when the bug is fixed and the waiver is removed.
  • Not verified in this review: whether the test passes on main, whether a narrower existing waiver exists, and the bug's test history.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Disables test_inforward_split on all platforms under NVBUG 7117673. Verify that the test passes again after the bug is fixed and then remove this line.

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@trtllm-agent
trtllm-agent marked this pull request as ready for review November 18, 2026 23:11
@trtllm-agent

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "auto-waive: waive-only change"

@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The skip list adds test_inforward_split from the Kimi K3 VL KDA metadata tests, with a reference to NVBUG 7117673.

Changes

Test waiver

Layer / File(s) Summary
Add test to skip list
tests/integration/test_lists/waives.txt
The skip list now includes test_inforward_split and references NVBUG 7117673.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · up to a59a7

This temporarily waives one failing Kimi K3 VL test under a tracked bug. Production behavior does not change. The only effect is reduced test coverage until the bug is resolved, so it is ready to merge.

Architecture risk: Low · up to a59a7

The change affects 1 system.

Changed systems: tests

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — tests (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in tests/integration/test_lists/waives.txt: Adds the test_inforward_split Kimi K3 VL test to the skip list, referencing NVBUG 7117673.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title uses the required NVBugs format and the [infra] type. It states a waiver of a failed test case on all platforms, which matches the changeset that adds one SKIP line to waives.txt. The title …
Description check Passed The description follows the repository template's main sections: a Description explaining the failure, bug link, scope, and restore condition, plus a Test Coverage section and checklist. The Test Cove…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title uses the required NVBugs format and the [infra] type. It states a waiver of a failed test case on all platforms, which matches the changeset that adds one SKIP line to waives.txt. The title names the bug ID and the action, but not the specific test. This is an acceptable summary of the single-line change.

Full details: Description check

Explanation

The description follows the repository template's main sections: a Description explaining the failure, bug link, scope, and restore condition, plus a Test Coverage section and checklist. The Test Coverage section contains no test list, only a note to review incident evidence. The PR Checklist is left unchecked for the reviewer. The template's title-format line and the Description section are covered. The description is mostly complete for a waiver-only change, though the Test Coverage section does not name specific tests.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
Fix failing CI checks

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 1f3b31b and a59a770.

Files selected for processing: 1

  • tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #85862 [ skip ] triggered by Bot. Commit: a59a770 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #85862 [ skip ] completed with state SUCCESS. Commit: a59a770
Skipping testing for commit a59a770

Link to invocation

@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@karljang
karljang merged commit a2d5d6d into NVIDIA:main Nov 19, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants