Repository navigation
Conversation
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #86350 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #86350 [ run ] completed with state
|
Collaborator
Author
|
/bot run |
Native request completion also covers context transmission in progress, so final-response readiness cannot authorize allocation teardown. Introduce explicit scheduling, response, and release predicates while preserving the existing transfer owners, connector load deferral, and collective boundaries. Publish responses before terminating their requests through one shared operation. When independent connector and transceiver completions race with a staged response, defer teardown until publication retains the routing. Retry early teardown after the last claim releases unless it actually completed, rather than skipping solely on the partial-reuse configuration. Track allocation release and terminal teardown independently, reset allocation state for replay, and retain completed PP consensus while local response or DMA owners drain. This prevents duplicate frees after cancellation during recompute and avoids requesting another vote from already-released PP peers. Add 27 CPU CI regression cases, including both dual-owner completion orders and the real two-rank PP termination handler with delayed publication. Validation: 1624 focused CPU tests passed (108 skipped, 65 deselected with the previously established connector baseline exclusions); 14 separately selected recompute tests passed. A100 Qwen validation passed 16 generation scenarios, cancellation and subsequent generation in both overlap modes, and four real IPC/RPC worker scenarios. Cross-GPU model and transfer validation remains pending because this container exposes one GPU. Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com> # Conflicts: # tensorrt_llm/_torch/pyexecutor/py_executor.py # Conflicts: # tensorrt_llm/_torch/pyexecutor/py_executor.py
Funatiq
force-pushed
the
dev/feat/response_release
branch
from
November 21, 2026 11:01
940ebcc to
506cd28
Compare
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #86524 [ run ] triggered by Bot. Commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Native request completion also covers context transmission in progress, so final-response readiness cannot authorize allocation teardown. Introduce explicit scheduling, response, and release predicates while preserving the existing transfer owners, connector load deferral, and collective boundaries.
Publish responses before terminating their requests through one shared operation. When independent connector and transceiver completions race with a staged response, defer teardown until publication retains the routing. Retry early teardown after the last claim releases unless it actually completed, rather than skipping solely on the partial-reuse configuration.
Track allocation release and terminal teardown independently, reset allocation state for replay, and retain completed PP consensus while local response or DMA owners drain. This prevents duplicate frees after cancellation during recompute and avoids requesting another vote from already-released PP peers.
Add 27 CPU CI regression cases, including both dual-owner completion orders and the real two-rank PP termination handler with delayed publication.
@coderabbitai summary
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.