Skip to content

[None][infra] Document the --commit option of bot commands and the blossom-ci.yml limits - #22688

Open
weiminwang-nv wants to merge 6 commits into
NVIDIA:mainfrom
weiminwang-nv:user/weimin/bot-run-commit
Open

weiminwang-nv wants to merge 6 commits into
NVIDIA:mainfrom
weiminwang-nv:user/weimin/bot-run-commit

Conversation

@weiminwang-nv

@weiminwang-nv weiminwang-nv commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • blossom-ci.yml change adds 22 comment lines only. The diff confirms that every added line is a comment. No workflow behavior changes. The earlier Community-PR-check job is not in this diff.
  • bot-command.yml changes help text only (+6/-5). It documents --commit FULL_SHA for run, skip, and reuse-pipeline, and states that external-organization PRs require it.
  • Risk: the help text states a requirement that this diff does not enforce. The CI handling is changed separately. Until that change lands, users may read the help as enforced when it is not.
  • Confirm that the separate parser and CI change deploys with or before this help text.

QA Engineer Review

No test changes.

Per-File QA Perspective

  • .github/workflows/blossom-ci.yml: Comments only. No QA-relevant behavior change.
  • .github/workflows/bot-command.yml: Verify that /bot help lists --commit FULL_SHA for run, skip, and reuse-pipeline. Verify the external-PR requirement text after the separate CI change is deployed.

Description

The /bot run, /bot skip and /bot reuse-pipeline commands get a new option --commit <full 40-character SHA>. It gives the commit that CI should test.

For pull requests from outside the NVIDIA GitHub organization the option is required, and it must be the latest commit of the pull request. This way CI only tests a commit that was reviewed.

The option is handled by the CI job that receives the command. That job is changed separately. This PR updates the /bot help text.

It also adds a comment to blossom-ci.yml that says what may be changed in that file. The Blossom runner compares the file with its template and rejects every /bot command when they differ, so an earlier version of this PR, which added a check job there, could not work. The runner compares the parsed YAML, so the comment does not change the result.

Test Coverage

Not needed. Only the help text and a comment change. The parsed YAML of blossom-ci.yml is the same as before.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Add a `--commit <full SHA>` option to `/bot run`, `/bot skip` and
`/bot reuse-pipeline`, so the comment can name the commit that CI
should test.

A new `Commit check` job in blossom-ci.yml runs before the CI job is
started:
- With `--commit`, the value must be the current head of the pull
  request.
- Without `--commit`, the command is accepted only when the author and
  the owner of the source repository are members of the NVIDIA GitHub
  organization. Other pull requests must use `--commit`.
- `/bot kill` is not changed.

The job only runs scripts from the default branch and calls GitHub
APIs. It does not check out pull request code.

Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
- Rename the job to `Community PR check` and run it before the
  vulnerability scan.
- Replace the script file with two inline steps. The first step checks
  if the pull request author is a member of the NVIDIA GitHub
  organization. For other authors, the second step checks that the
  command has `--commit` with the full SHA of the pull request head.
- Remove the script, its tests and the doc change.

Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
… check

The job only reads the pull request and comments on it. The
`pull-requests: write` permission is enough for both.

Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
@weiminwang-nv
weiminwang-nv marked this pull request as ready for review November 20, 2026 14:02
@weiminwang-nv
weiminwang-nv requested a review from a team as a code owner November 20, 2026 14:02
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Bot help documents --commit FULL_SHA for run, skip, and reuse-pipeline. It states that external pull requests must provide the option. Comments describe Blossom workflow-template requirements, editing restrictions, and testing constraints.

Changes

Bot command guidance

Layer / File(s) Summary
Document the commit option
.github/workflows/bot-command.yml
Help text adds --commit FULL_SHA to run, skip, and reuse-pipeline. It states that external pull requests must provide the option.

Blossom workflow guidance

Layer / File(s) Summary
Document Blossom workflow restrictions
.github/workflows/blossom-ci.yml
Comments describe the workflow-template matching requirement, permitted and prohibited edits, default-branch execution, and where to find comparison rules.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: Minimal · up to 632cd

This PR updates the /bot help text to describe the --commit option and adds explanatory comments to the Blossom workflow file. It makes no functional change, so merge risk is negligible.

Architecture risk: Low · up to 2cb37

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/blossom-ci.yml: Adds Community-PR-check, which checks pull request authors’ NVIDIA membership unless the comment is /bot kill. A successful membership lookup returns an internal-author result; any lookup error treats the author as external, with non-404 errors also producing a warning.
  • observed — Modified behavior in .github/workflows/blossom-ci.yml: For external authors, checks whether the normalized command contains the exact PR head SHA after --commit, with spaces preventing partial matches. Otherwise, the job fails and posts a comment instructing the author to review and provide the latest full SHA.
  • observed — Modified behavior in .github/workflows/blossom-ci.yml: Vulnerability-scan now depends on both Authorization and Community-PR-check, rather than only Authorization.
  • observed — Modified behavior in .github/workflows/bot-command.yml: The run help entry adds --commit FULL_SHA to its usage and documents it as optional, required for pull requests from outside the NVIDIA GitHub organization, and accepted by skip and reuse-pipeline.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the two changes in the PR: documenting the new --commit option of the bot commands, and the blossom-ci.yml limits comment. Both match the changeset. The title follows the repository te…
Description check Passed The description covers what and why. It explains the new --commit option, the external-PR requirement, and the reason for the blossom-ci.yml comment. The Test Coverage section gives a reason for havin…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two changes in the PR: documenting the new --commit option of the bot commands, and the blossom-ci.yml limits comment. Both match the changeset. The title follows the repository template with the [None][infra] prefix. It is long, but it covers the main change.

Full details: Description check

Explanation

The description covers what and why. It explains the new --commit option, the external-PR requirement, and the reason for the blossom-ci.yml comment. The Test Coverage section gives a reason for having no tests. The template's Description and Test Coverage sections are present and filled in. The checklist is marked. The description does not link to a JIRA ticket or NVBugs ID, and the template does not require one when the ticket is None.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between ede74df and 632cd4f.

Files selected for processing: 1

  • .github/workflows/blossom-ci.yml
Files skipped from review as they are similar to previous changes: 1

  • .github/workflows/blossom-ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@weiminwang-nv

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "The change workflow itself can only run after this PR is merged"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #86400 [ skip ] triggered by Bot. Commit: 2cb37ef Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #86400 [ skip ] completed with state SUCCESS. Commit: 2cb37ef
Skipping testing for commit 2cb37ef

Link to invocation

The Blossom runner compares blossom-ci.yml with its template and
rejects the file when it has a job that the template does not have.
With the extra job, every /bot command would be rejected.

The check stays in the CI job that receives the command.

Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
@weiminwang-nv weiminwang-nv changed the title [None][infra] Require --commit for bot commands on external PRs [None][infra] Document the --commit option of bot commands Nov 21, 2026
…om-ci.yml

Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
@weiminwang-nv weiminwang-nv changed the title [None][infra] Document the --commit option of bot commands [None][infra] Document the --commit option of bot commands and the blossom-ci.yml limits Nov 21, 2026
@weiminwang-nv

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "The change workflow itself can only run after this PR is merged"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #86518 [ skip ] triggered by Bot. Commit: ede74df Link to invocation

Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #86518 [ skip ] completed with state SUCCESS. Commit: ede74df
Skipping testing for commit ede74df

Link to invocation

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants