Repository navigation
[None][infra] Document the --commit option of bot commands and the blossom-ci.yml limits - #22688
weiminwang-nv wants to merge 6 commits into
Conversation
Add a `--commit <full SHA>` option to `/bot run`, `/bot skip` and `/bot reuse-pipeline`, so the comment can name the commit that CI should test. A new `Commit check` job in blossom-ci.yml runs before the CI job is started: - With `--commit`, the value must be the current head of the pull request. - Without `--commit`, the command is accepted only when the author and the owner of the source repository are members of the NVIDIA GitHub organization. Other pull requests must use `--commit`. - `/bot kill` is not changed. The job only runs scripts from the default branch and calls GitHub APIs. It does not check out pull request code. Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
- Rename the job to `Community PR check` and run it before the vulnerability scan. - Replace the script file with two inline steps. The first step checks if the pull request author is a member of the NVIDIA GitHub organization. For other authors, the second step checks that the command has `--commit` with the full SHA of the pull request head. - Remove the script, its tests and the doc change. Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
… check The job only reads the pull request and comments on it. The `pull-requests: write` permission is enough for both. Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
|
No actionable comments were generated in the recent review. WalkthroughBot help documents ChangesBot command guidance
Blossom workflow guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk:
|
|
/bot skip --comment "The change workflow itself can only run after this PR is merged" |
|
PR_Github #86400 [ skip ] triggered by Bot. Commit: |
|
PR_Github #86400 [ skip ] completed with state |
The Blossom runner compares blossom-ci.yml with its template and rejects the file when it has a job that the template does not have. With the extra job, every /bot command would be rejected. The check stays in the CI job that receives the command. Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
…om-ci.yml Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
|
/bot skip --comment "The change workflow itself can only run after this PR is merged" |
|
PR_Github #86518 [ skip ] triggered by Bot. Commit: |
Signed-off-by: Weimin Wang <301118019+weiminwang-nv@users.noreply.github.com>
|
PR_Github #86518 [ skip ] completed with state |
Dev Engineer Review
blossom-ci.ymlchange adds 22 comment lines only. The diff confirms that every added line is a comment. No workflow behavior changes. The earlierCommunity-PR-checkjob is not in this diff.bot-command.ymlchanges help text only (+6/-5). It documents--commit FULL_SHAforrun,skip, andreuse-pipeline, and states that external-organization PRs require it.QA Engineer Review
No test changes.
Per-File QA Perspective
.github/workflows/blossom-ci.yml: Comments only. No QA-relevant behavior change..github/workflows/bot-command.yml: Verify that/bot helplists--commit FULL_SHAforrun,skip, andreuse-pipeline. Verify the external-PR requirement text after the separate CI change is deployed.Description
The
/bot run,/bot skipand/bot reuse-pipelinecommands get a new option--commit <full 40-character SHA>. It gives the commit that CI should test.For pull requests from outside the NVIDIA GitHub organization the option is required, and it must be the latest commit of the pull request. This way CI only tests a commit that was reviewed.
The option is handled by the CI job that receives the command. That job is changed separately. This PR updates the
/bot helptext.It also adds a comment to
blossom-ci.ymlthat says what may be changed in that file. The Blossom runner compares the file with its template and rejects every/botcommand when they differ, so an earlier version of this PR, which added a check job there, could not work. The runner compares the parsed YAML, so the comment does not change the result.Test Coverage
Not needed. Only the help text and a comment change. The parsed YAML of
blossom-ci.ymlis the same as before.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.