Skip to content

[None][chore] promote flashinfer-prims-ts source from #19395 - #22723

Merged
yuxianq merged 1 commit into
NVIDIA:mainfrom
yuxianq:chore/flashinfer-prims-ts-promote-19395-d76f94bb6ae3
Nov 21, 2026
Merged

yuxianq merged 1 commit into
NVIDIA:mainfrom
yuxianq:chore/flashinfer-prims-ts-promote-19395-d76f94bb6ae3

Conversation

@yuxianq

@yuxianq yuxianq commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • 3rdparty/vendor_sources.lock.yaml: the flashinfer-prims-ts branch changes from prims-ts-fmha-lib--cp-dev-task-api-20261119 to trtllm-prims-ts-dev-20261107. The commit, source, destination, and other fields are unchanged. The diff confirms this single-line change.
  • No source, runtime, API, or dependency changes.
  • Risk: the lock now points to a different branch name. The pinned commit still controls the content, so the source should not change.

QA Engineer Review

No test changes.

Per-File QA Perspective

  • 3rdparty/vendor_sources.lock.yaml (configuration): the vendor branch reference changes. QA does not need runtime checks beyond confirming the pinned commit still materializes.

Description

Promote the exact source revision reviewed in #19395.
Only vendors.flashinfer-prims-ts in 3rdparty/vendor_sources.lock.yaml changes its URL/branch. The source SHA, selected vendor files, compatibility patch, and digests are unchanged.

Test Coverage

Source materialization and lock-only diff verified by the promotion tool. No new kernel behavior. The tool posts /bot skip --comment "skip CI since no code change" to request the bot's no-code-change CI path. Automatic GitHub checks and required reviews still apply.

PR Checklist

  • No runtime/API/dependency changes.
  • Immutable source pin and vendor content preserved.
  • Please check this after reviewing the above items as appropriate for this PR.

Required squash commit message

Preserve the following message, including the provenance block and DCO sign-off.

[None][chore] promote flashinfer-prims-ts source from #19395

----- BEGIN VENDOR PROMOTION V1 -----
{
  "attribution": {
    "5129a714e7f3e1c45a7127425fe5173b1f1f9e87": {
      "method": "same-edits",
      "upstream_base": "a7d9e18658d3954527675a3d3a9e7b2ec75b2eae",
      "upstream_head": "f276b1561a484fecca055cee1a35e4d8901f992b"
    },
    "9cc9333bfe89eb4d5e9d9dd5e87e0bcb275e8b27": {
      "comparison": {
        "source_base": "31fe2dbd6b65cca758c1318f177b315be0c33778",
        "source_head": "9cc9333bfe89eb4d5e9d9dd5e87e0bcb275e8b27",
        "upstream_base": "1bdba872568a87391f64ffb91910e52aeff9479d",
        "upstream_head": "9ff50c4e324b56869670b70ea64dcf525bc94b85"
      },
      "method": "similar-upstream-aggregate",
      "refresh_policy": "retain-until-verified",
      "similarity": 0.9989658738366081,
      "similarity_metric": "sequence-matcher-lines-v1",
      "similarity_threshold": 0.9,
      "upstream_base": "1bdba872568a87391f64ffb91910e52aeff9479d",
      "upstream_head": "9ff50c4e324b56869670b70ea64dcf525bc94b85",
      "upstream_pr": 5489
    },
    "d76f94bb6ae3bc1730689a1a080a79913dcc3606": {
      "method": "same-edits",
      "upstream_base": "a7d9e18658d3954527675a3d3a9e7b2ec75b2eae",
      "upstream_head": "f276b1561a484fecca055cee1a35e4d8901f992b"
    }
  },
  "attribution_scope": {
    "include": [
      "**/*.py"
    ],
    "source": "flashinfer/attention/prims_ts"
  },
  "canonical_branch": "trtllm-prims-ts-dev-20261107",
  "canonical_url": "https://github.com/yuxianq/flashinfer.git",
  "changes": [
    {
      "commits": [
        "9cc9333bfe89eb4d5e9d9dd5e87e0bcb275e8b27"
      ],
      "upstream_base": "1bdba872568a87391f64ffb91910e52aeff9479d",
      "upstream_head": "9ff50c4e324b56869670b70ea64dcf525bc94b85",
      "upstream_merge": "1a9f361db34977801e4a676eb54b0379527479b9",
      "upstream_pr": "https://github.com/flashinfer-ai/flashinfer/pull/5489"
    },
    {
      "commits": [
        "5129a714e7f3e1c45a7127425fe5173b1f1f9e87",
        "d76f94bb6ae3bc1730689a1a080a79913dcc3606"
      ],
      "upstream_base": "a7d9e18658d3954527675a3d3a9e7b2ec75b2eae",
      "upstream_head": "f276b1561a484fecca055cee1a35e4d8901f992b",
      "upstream_merge": "0cf9d70d8db1dbc74dc34a4d69c33b60602414ac",
      "upstream_pr": "https://github.com/flashinfer-ai/flashinfer/pull/9641"
    }
  ],
  "consumer_base": "main",
  "consumer_merge": "464b458a34696ee42a3206cb5ba4d231f3ac0a0f",
  "consumer_pr": "https://github.com/NVIDIA/TensorRT-LLM/pull/19395",
  "contributor_metadata": {
    "metadata_digest": "f6066e75990b21c7bc5fef79f79df588eabdc27341a03382b4c6d086a311c85a",
    "pr_author": "yuxianq",
    "source_head": "f2300c7b0a971b0d99e57fdc736d51e5ee47704a"
  },
  "kind": "promotion",
  "previous": "31fe2dbd6b65cca758c1318f177b315be0c33778",
  "promoted": "d76f94bb6ae3bc1730689a1a080a79913dcc3606",
  "source_branch": "prims-ts-fmha-lib--cp-dev-task-api-20261119",
  "source_url": "https://github.com/yuxianq/flashinfer.git",
  "upstream_base": "911d6a9d62308b6c8a5249e8dc4aabc7518020f1",
  "upstream_branch": "main",
  "upstream_observed_main": "ceb7af388d41ae3532f27de3750375ef7efc29aa",
  "upstream_repository": "flashinfer-ai/flashinfer",
  "vendor": "flashinfer-prims-ts",
  "version": 1
}
----- END VENDOR PROMOTION V1 -----

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>

----- BEGIN VENDOR PROMOTION V1 -----
{
  "attribution": {
    "5129a714e7f3e1c45a7127425fe5173b1f1f9e87": {
      "method": "same-edits",
      "upstream_base": "a7d9e18658d3954527675a3d3a9e7b2ec75b2eae",
      "upstream_head": "f276b1561a484fecca055cee1a35e4d8901f992b"
    },
    "9cc9333bfe89eb4d5e9d9dd5e87e0bcb275e8b27": {
      "comparison": {
        "source_base": "31fe2dbd6b65cca758c1318f177b315be0c33778",
        "source_head": "9cc9333bfe89eb4d5e9d9dd5e87e0bcb275e8b27",
        "upstream_base": "1bdba872568a87391f64ffb91910e52aeff9479d",
        "upstream_head": "9ff50c4e324b56869670b70ea64dcf525bc94b85"
      },
      "method": "similar-upstream-aggregate",
      "refresh_policy": "retain-until-verified",
      "similarity": 0.9989658738366081,
      "similarity_metric": "sequence-matcher-lines-v1",
      "similarity_threshold": 0.9,
      "upstream_base": "1bdba872568a87391f64ffb91910e52aeff9479d",
      "upstream_head": "9ff50c4e324b56869670b70ea64dcf525bc94b85",
      "upstream_pr": 5489
    },
    "d76f94bb6ae3bc1730689a1a080a79913dcc3606": {
      "method": "same-edits",
      "upstream_base": "a7d9e18658d3954527675a3d3a9e7b2ec75b2eae",
      "upstream_head": "f276b1561a484fecca055cee1a35e4d8901f992b"
    }
  },
  "attribution_scope": {
    "include": [
      "**/*.py"
    ],
    "source": "flashinfer/attention/prims_ts"
  },
  "canonical_branch": "trtllm-prims-ts-dev-20261107",
  "canonical_url": "https://github.com/yuxianq/flashinfer.git",
  "changes": [
    {
      "commits": [
        "9cc9333bfe89eb4d5e9d9dd5e87e0bcb275e8b27"
      ],
      "upstream_base": "1bdba872568a87391f64ffb91910e52aeff9479d",
      "upstream_head": "9ff50c4e324b56869670b70ea64dcf525bc94b85",
      "upstream_merge": "1a9f361db34977801e4a676eb54b0379527479b9",
      "upstream_pr": "flashinfer-ai/flashinfer#5489"
    },
    {
      "commits": [
        "5129a714e7f3e1c45a7127425fe5173b1f1f9e87",
        "d76f94bb6ae3bc1730689a1a080a79913dcc3606"
      ],
      "upstream_base": "a7d9e18658d3954527675a3d3a9e7b2ec75b2eae",
      "upstream_head": "f276b1561a484fecca055cee1a35e4d8901f992b",
      "upstream_merge": "0cf9d70d8db1dbc74dc34a4d69c33b60602414ac",
      "upstream_pr": "flashinfer-ai/flashinfer#9641"
    }
  ],
  "consumer_base": "main",
  "consumer_merge": "464b458a34696ee42a3206cb5ba4d231f3ac0a0f",
  "consumer_pr": "NVIDIA#19395",
  "contributor_metadata": {
    "metadata_digest": "f6066e75990b21c7bc5fef79f79df588eabdc27341a03382b4c6d086a311c85a",
    "pr_author": "yuxianq",
    "source_head": "f2300c7b0a971b0d99e57fdc736d51e5ee47704a"
  },
  "kind": "promotion",
  "previous": "31fe2dbd6b65cca758c1318f177b315be0c33778",
  "promoted": "d76f94bb6ae3bc1730689a1a080a79913dcc3606",
  "source_branch": "prims-ts-fmha-lib--cp-dev-task-api-20261119",
  "source_url": "https://github.com/yuxianq/flashinfer.git",
  "upstream_base": "911d6a9d62308b6c8a5249e8dc4aabc7518020f1",
  "upstream_branch": "main",
  "upstream_observed_main": "ceb7af388d41ae3532f27de3750375ef7efc29aa",
  "upstream_repository": "flashinfer-ai/flashinfer",
  "vendor": "flashinfer-prims-ts",
  "version": 1
}
----- END VENDOR PROMOTION V1 -----

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@yuxianq
yuxianq requested review from a team as code owners November 21, 2026 00:28
@yuxianq
yuxianq requested review from heyuhhh and lfr-0531 November 21, 2026 00:28
@yuxianq

yuxianq commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "skip CI since no code change"

@yuxianq
yuxianq enabled auto-merge (squash) November 21, 2026 00:29
@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The flashinfer-prims-ts vendor entry now tracks branch trtllm-prims-ts-dev-20261107. Its commit, source, destination, include pattern, patch, and digests remain unchanged.

Changes

Vendor branch tracking

Layer / File(s) Summary
Update tracked branch
3rdparty/vendor_sources.lock.yaml
The flashinfer-prims-ts entry now tracks trtllm-prims-ts-dev-20261107. Other vendor entry fields remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: Minimal · up to fc85c

This is a lock-only change to the fallback branch of a vendored source. The pinned commit and digests are unchanged, so builds fetch the same source as before. Any fallback failure would surface as an explicit error rather than silent substitution. There is no actionable merge risk.

Architecture risk: Low · up to fc85c

The change affects 1 system.

Changed systems: 3rdparty

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — 3rdparty (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in 3rdparty/vendor_sources.lock.yaml: The flashinfer-prims-ts vendor entry switches its tracked branch from prims-ts-fmha-lib--cp-dev-task-api-20261119 to trtllm-prims-ts-dev-20261107.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "[None][chore] promote flashinfer-prims-ts source from #19395" follows the repository template (no ticket, type [chore]). It names the main change: promoting the flashinfer-prims-ts vendor s…
Description check Passed The description covers the main required content. It explains the promotion of the reviewed source revision from PR #19395 and states that only the vendor URL and branch change. It includes a Test Cov…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "[None][chore] promote flashinfer-prims-ts source from #19395" follows the repository template (no ticket, type [chore]). It names the main change: promoting the flashinfer-prims-ts vendor source. The changeset only updates the URL and branch for that vendor entry in the lock file, so the title matches the change.

Full details: Description check

Explanation

The description covers the main required content. It explains the promotion of the reviewed source revision from PR #19395 and states that only the vendor URL and branch change. It includes a Test Coverage section and a completed PR checklist. The provenance block and sign-off are present in the commit message. The Description and Test Coverage sections are brief, and the checklist adds a generic 'no runtime/API/dependency changes' item, but the description is mostly complete and matches the template's intent.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 75749ff and fc85c73.

Files selected for processing: 1

  • 3rdparty/vendor_sources.lock.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #86478 [ skip ] triggered by Bot. Commit: fc85c73 Link to invocation

@yuxianq

yuxianq commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator Author

@yihwang-nv, could you help to review this PR as trt-llm-torch-attention-devs? Thanks~

Assignment explanation
Componentsintegration/dependencies (100%)
TagsNone identified
PR effort1 points — A single branch-name substitution takes one hunk to review. The adjacent commit pin makes the selected revision explicit.
Affinity (0–1)0.378 component/tag match
Affinity evidenceMerged authorship 2 × √points; first review 1 × √points; global normalization 0.744092
Outstanding points at selection20 → 21 (+1)
Points already reserved on this PR0
Effective weight1
Completed review points (preceding 168 hours)21
Combined points after assignment42
Demand-derived target42.00 points (soft share)
Additional fair share before assignment1.00 points
Share explanationWithin demand-derived share.
Selection rulebalance-first maintenance
Assignment scope (yihwang-nv)all

Affinity and workload are snapshots at selection, not live counters. Existing reservations on this PR are counted once.

@yuxianq
yuxianq requested review from yihwang-nv and removed request for heyuhhh and lfr-0531 November 21, 2026 00:38
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #86478 [ skip ] completed with state SUCCESS. Commit: fc85c73
Skipping testing for commit fc85c73

Link to invocation

@harrisonzhy
harrisonzhy requested a review from heyuhhh November 21, 2026 01:08
@yuxianq
yuxianq merged commit 0a8fa7f into NVIDIA:main Nov 21, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants