[API] Run, get, list experiments - #1063
podkidyshev wants to merge 11 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Repository: NVIDIA/cloudai/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA/cloudai/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (12)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe change adds reusable experiment setup and execution, public functions to run and retrieve experiments, and CLI signal and compatibility handling. Parser errors can propagate to API callers, and runner construction accepts an explicit runner class. ChangesExperiment lifecycle
Priority: ⬇️ Low Estimated code review effort: 4 (Complex) | ~40 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The experiment API preserves failure-status finalization and rejects unsupported scheduler configurations. No concrete issue remains that should block merging after normal checks. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
1c5300b to
a5e6a3a
Compare
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
bbb9ad1 to
2ad2a21
Compare
| import click | ||
|
|
||
| import cloudai.core | ||
| import cloudai.handlers |
Summary
cloudai.apientry points to run scenarios from configuration paths and list or load their unified experiment output.experiment.json.Experimentthroughon_startafterexperiment.jsonis created, allowing wrappers to obtain the real experiment ID while synchronous execution continues.Test Plan
Additional Notes
Based on #1049.
run_experimentremains synchronous; callers decide whether to execute it in a background process.