feat: add metric observations for vLLM and SGLang - #1068
Draft
podkidyshev wants to merge 3 commits into
Draft
podkidyshev wants to merge 3 commits into
podkidyshev wants to merge 3 commits into
Conversation
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
Signed-off-by: Ivan Podkidyshev <ipodkidyshev@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metric_observationsto vLLM and SGLang for request throughput (requests/s), output-token throughput (tokens/s), TTFT/TPOT (ms), and optional semantic accuracy.statistic(mean,median,p99); throughput and accuracy have empty dimensions. Workload, model, and configured concurrency remain in the test/run context.Test Plan
Environment: macOS, Python 3.14.3, locked development dependencies.
Ran
uv run --locked --extra dev pre-commit run --filesfor changed files, including pyright, Ruff, vulture, and import-linter. All applicable checks passed after reviewing formatter edits.git diff --checkpassed.Replayed five locally fetched benchmark executions without changing their result files. TestRun objects were reconstructed from saved metadata; historical SGLang semantic-evaluation settings were enabled in memory using the current schema.
Built the documentation using
uv run --locked --extra dev --extra docs sphinx-build -W -b html doc results/llm-metrics-docs-movewith no warnings, and inspected both workload pages: five metric rows, the TOML example, and the reporting link render correctly.doc/reporting.rsthas no changes relative to the PR base.Additional Notes
This PR adds observation support. Built-in vLLM/SGLang comparison reporters retain their existing scalar path; NCCL/NIXL observations are outside this change's scope.
The generic metric comparison reporter's legacy Bokeh renderer has a known failure on categorical dimensions such as mean/median/p99 (
TypeErrorwhile calculating numeric ticks). Reporter integration and that rendering fix are separate work.Local replay scripts, fetched results, and generated artifacts are not committed. SOL values used for validation are illustrative, not hardware performance claims. No remote benchmark jobs were run.