Repository navigation
Conversation
…i. fix: expanded check for EC_API_URL for juno using cli
Tomi-3-0
force-pushed
the
feat/juno-on-sedge
branch
from
December 7, 2023 21:34
83db1af to
bdfc4d0
Compare
Tomi-3-0
marked this pull request as ready for review
December 8, 2023 10:33
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #333 +/- ##
===========================================
+ Coverage 86.13% 86.48% +0.35%
===========================================
Files 78 78
Lines 4558 4832 +274
===========================================
+ Hits 3926 4179 +253
- Misses 547 562 +15
- Partials 85 91 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cbermudez97
reviewed
Dec 14, 2023
cbermudez97
left a comment
Contributor
There was a problem hiding this comment.
In general LGTM. Good job adding Juno to Sedge. Just some minors questions.
cbermudez97
reviewed
Dec 14, 2023
cbermudez97
left a comment
Contributor
There was a problem hiding this comment.
In general LGTM. Good job adding Juno to Sedge. Just some minors questions.
…ests for get_Containers test
…into feat/juno-on-sedge merge
…mplates for non-supported networks
Tomi-3-0
requested review from
cbermudez97 and
stdevMac
and removed request for
cbermudez97
December 26, 2023 12:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes | Closes | Resolves #
Changes:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Comments about testing , should you have some (optional)
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...