Repository navigation
Fix static analysis warnings and defects identified #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GermanAizek
wants to merge
25
commits into
NetworkConfiguration:master
Choose a base branch
from
GermanAizek:fix-static-analyzer-clang
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
51e8200
if-options: remove duplicate DHO_SUBNETMASK in set_default_allow
0a5c24f
if-options: handle NULL ldop and edop safely in parse_option
baa6a9b
common: fix preprocessor macro typo for GCC version check
44684d2
dhcp6: use ia.iaid instead of uninitialized iaid buffer
201c1b2
ipv4: remove redundant pointer check in IPV4_MASK1_EQ and IPV4_BRD1_EQ
6aed0e6
ipv6: guard against NULL router pointer in inet6_makeprefix
1febd6e
if-linux: check ctx for NULL before checking sequence in if_getnetlink
71ee976
ipv4: allow CIDR /0 in inet_cidrtoaddr
b0bacf9
arp: initialize falen to prevent reading uninitialized memory
b8949c4
ipv4ll: prevent passing NULL prefix to efprintf
7e75c5e
dhcpcd: handle NULL ifname safely in single-interface check
c6c9fc6
dhcp: prevent uint8_t overflow on clientid length and remove dead nol…
2746e15
dhcp-common: clean up unreachable break, duplicate assignment, and re…
f3faa50
if-linux: prevent signed integer overflow when incrementing netlink s…
5b4c29a
privsep-root: remove dead pid check and redundant NULL check
64a0c03
dhcp6: remove redundant conditions in delegateaddr and sendmessage
8c4b12b
ipv6nd: remove redundant expired check in router expiry loop
21cfc3a
if-options: fix setting auth algorithm instead of protocol for token
d439b3d
ipv4: avoid use-after-free of ap in ipv4_deleteaddr
9e9d353
ipv6: check for NULL state returned by ipv6_getstate
7f2075a
dhcpcd: return early if ifp->options is NULL in dhcpcd_handlecarrier
953b576
dhcp: remove duplicate *bootp = NULL assignment in read_lease
b136abf
ipv4: clarify operator precedence in inet_cidrtoaddr netmask calculation
5808770
duid: parenthesize DUID_LEN and DUID_STRLEN to fix buffer size calcul…
83de2d1
macros: parenthesize expressions and parameters to prevent operator p…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preserve definition arguments for later parsing.
With
--define "224 string custom" --metric 100 eth0, the initial call now succeeds. However,parse_optionreplaces spaces inoptargwith NUL. Whenconfigure_interfaceparses the retainedargvagain, the definition argument is only"224". Parsing returns-1and skips--metricand all later options. The caller continues without applying those options. Parse a temporary copy of definition arguments and release it after parsing. This preserves both the first application and later applications. (raw.githubusercontent.com)