Conversation
yankinmax
changed the title
|
the reason is not "edi core revamp". The dependency on endpoint module is wrong by itself and I don't know why it has been added 😉 |
simahawk
changed the title
|
@simahawk good to know, thanks |
|
I'm checking the test issue |
|
@yankinmax I've not managed to fix this yet. Do me a favor: live it like it is today w/ the dependency but add a TODO and report there the motivation. A simple glue module for edi_product + endpoint does not work as it does for edi_sale_endpoint so... let's not waste too much time on something that is like that since ages. |
79f4350 to
c436cba
Compare
|
@simahawk done! |
|
@yankinmax pls rewrite the commit msg |
The direct dependency on edi_endpoint_oca is not conceptually correct: edi_product_oca should only need edi_core_oca. However, removing edi_endpoint_oca on 18.0 currently breaks CI because origin_edi_endpoint_id can be set up on product models while its related target edi.exchange.record.edi_endpoint_id is missing. Keep the dependency for now and add a TODO comment to remove it in version 19.0
c436cba to
40e2366
Compare
SilvioC2C
left a comment
SilvioC2C
left a comment
There was a problem hiding this comment.
LGTM, I proposed a minor improvement to the comment (since we already have removed that module dependency in v19 😉)
| # TODO: Replace this dependency with ``edi_core_oca`` in version 19.0 | ||
| # For version 18.0 without ``edi_endpoint_oca``, CI fails | ||
| # because ``origin_edi_endpoint_id`` is set up on product models | ||
| # while its related target ``edi.exchange.record.edi_endpoint_id`` is absent. | ||
| # A glue module similar to ``edi_sale_endpoint`` does not currently solve it. |
There was a problem hiding this comment.
| # TODO: Replace this dependency with ``edi_core_oca`` in version 19.0 | |
| # For version 18.0 without ``edi_endpoint_oca``, CI fails | |
| # because ``origin_edi_endpoint_id`` is set up on product models | |
| # while its related target ``edi.exchange.record.edi_endpoint_id`` is absent. | |
| # A glue module similar to ``edi_sale_endpoint`` does not currently solve it. | |
| # Deprecated in favor of ``edi_core_oca`` in version 19.0 | |
| # In 18.0, CI would fail a direct dependency on ``edi_endpoint_oca``, | |
| # because ``origin_edi_endpoint_id`` is set up on products | |
| # while its related target ``edi.exchange.record.edi_endpoint_id`` is absent. | |
| # A glue module similar to ``edi_sale_endpoint`` does not currently solve it. |
|
This PR has the |
5 participants
See requested changes:
cc @simahawk