Repository navigation
[MIG] Migrate mail_suggested_recipient_unchecked to 19.0 - #279
Open
camille-spiritus-acs wants to merge 10 commits into
Open
camille-spiritus-acs wants to merge 10 commits into
camille-spiritus-acs wants to merge 10 commits into
Conversation
TT51197 [UPD] Update mail_suggested_recipient_unchecked.pot [BOT] post-merge updates
Currently translated at 100.0% (1 of 1 strings) Translation: mail-18.0/mail-18.0-mail_suggested_recipient_unchecked Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_suggested_recipient_unchecked/de/
In 19.0 the suggested recipients mechanism was rewritten, so the 18.0 implementation (returning `checked: False` from Python) no longer works: - odoo/odoo@8f3ea98 "[REF] mail, various: improve suggested recipients": removes `mail.thread._message_add_suggested_recipient`, the method overridden in 18.0. - odoo/odoo@3b985d2 "[IMP] mail: allow user to add new recipients in the chatter": replaces the suggested recipient checkboxes by a "To" field (RecipientsInput) and drops the `checked` attribute. Every recipient in `thread.suggestedRecipients` is now notified. - odoo/odoo@4ceb3f6 "[IMP] mail: make suggested recipients batch-enabled": computation now lives in `_message_get_suggested_recipients_batch`. The module is therefore reimplemented on the web client side: - suggested recipients received from the server are moved from `suggestedRecipients` to a new `uncheckedSuggestedRecipients` thread field, so they are not notified by default; - they are displayed next to the "To" field as clickable suggestions, a click adding them to the additional recipients. The Python override is removed and the test is replaced by a tour.
OCA-git-bot
added
series:19.0
mod:mail_suggested_recipient_unchecked
petrus-v
reviewed
Oct 7, 2026
petrus-v
left a comment
petrus-v
left a comment
There was a problem hiding this comment.
thanks for this migration !
Migration code looks good pretty good and I've tested on runboat, seems works like a charm.
I think you should declare your module or the mail_restrict_send_button module as rebel module in order to make the CI works using copier update.
Does this module use to change the composer behavior as well or only the embedded chatter view?
I'm wondering how odoo determine the contact name, here OpenWood, but I haven't deep into that code and I guess this is out of the scope of this module ^^
petrus-v
approved these changes
Oct 8, 2026
petrus-v
left a comment
petrus-v
left a comment
There was a problem hiding this comment.
Thanks for this nice migration. It's good to see tours !
I've double checked the behavior on v18 and seems consistent to me !
camille-spiritus-acs
force-pushed
the
19.0-mig-mail_suggested_recipient_unchecked
branch
from
October 8, 2026 09:33
879b680 to
3790d54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 19.0 the suggested recipients mechanism was rewritten, so the 18.0
implementation (returning
checked: Falsefrom Python) no longer works.The module is therefore reimplemented on the web client side:
suggestedRecipientsto a newuncheckedSuggestedRecipientsthreadfield, so they are not notified by default;
a click adding them to the additional recipients.