Skip to content

[19.0][MIG] mail_autogenerated_header - #282

Open
JasminSForgeFlow wants to merge 13 commits into
OCA:19.0from
ForgeFlow:19.0-mig-mail_autogenerated_header
Open

JasminSForgeFlow wants to merge 13 commits into
OCA:19.0from
ForgeFlow:19.0-mig-mail_autogenerated_header

Conversation

@JasminSForgeFlow

Copy link
Copy Markdown
Contributor

Standard Migration

Replaces mail_thread_subject_ignore in OCA/mail.

Supersedes #179. Related: #85

  • Tests: use _build_email__ and a test user (no demo data in 19.0); run them post_install.
  • Fix: suppressed _notify_thread returns [] instead of False (crashed with sms installed).
  • Fix: setting the parameter to False in the UI now disables the headers.

@ForgeFlow

@OCA-git-bot OCA-git-bot added series:19.0 mod:mail_autogenerated_header Module mail_autogenerated_header labels Oct 5, 2026
@JasminSForgeFlow
JasminSForgeFlow force-pushed the 19.0-mig-mail_autogenerated_header branch from 1fffbb5 to a5d6e40 Compare October 5, 2026 12:15
@OCA-git-bot OCA-git-bot added the mod:mail_tracking Module mail_tracking label Oct 5, 2026

@AaronHForgeFlow AaronHForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional + code

Comment on lines +41 to +43
message["Auto-Submitted"]
and message["Auto-Submitted"] != "no"
or message["X-Auto-Response-Suppress"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, but i'd use message.get("Auto-Submitted") and message.get("X-Auto-Response-Suppress"), just in case for some reason message did not came as Message object

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Thanks

@AaronHForgeFlow

Copy link
Copy Markdown
Contributor

Perhaps you can open another PR for the fix in the mail_tracking module

@JasminSForgeFlow
JasminSForgeFlow force-pushed the 19.0-mig-mail_autogenerated_header branch from a5d6e40 to 80006b2 Compare October 6, 2026 03:35
@JasminSForgeFlow

Copy link
Copy Markdown
Contributor Author

Perhaps you can open another PR for the fix in the mail_tracking module

Done, Thanks

@OCA-git-bot OCA-git-bot removed the mod:mail_tracking Module mail_tracking label Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:mail_autogenerated_header Module mail_autogenerated_header series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants