Skip to content

Cleanup old Component Constructors - #627

Open
lukelowry wants to merge 2 commits into
developfrom
lukel/component-constructor-dev
Open

lukelowry wants to merge 2 commits into
developfrom
lukel/component-constructor-dev

Conversation

@lukelowry

Copy link
Copy Markdown
Collaborator

Description

Every PhasorDynamics component now has a single constructor, Model(BusT* ..., const ModelDataT& data) or Model(const ModelDataT& data). This precedes removing BusT* from the constructors, which will be helpful in partitioning/hierarchy

Proposed changes

  • Remove the default, bus-only, positional-parameter, and signal-pointer constructors from 16 components.
  • Update tests to construct components from model data.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • N/A There are unit tests for the new code.
  • N/A The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • N/A The CHANGELOG.md has been updated to reflect the changes.

Further comments

Buses keep their constructors, to keep changes low

@lukelowry
lukelowry requested a review from nkoukpaizan October 21, 2026 08:23
@lukelowry
lukelowry marked this pull request as ready for review October 21, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant