r.in.ascii: migrate tests from gunittest to pytest - #7780
Open
Valyrian-Code wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
raster
echoix
requested changes
Jul 27, 2026
Restore the original stdin data (all cells 1..15, no NULLs, so min=1/max=15) instead of injecting -9999 values, and keep the external-file content byte-identical including its trailing newline. Assert the null-cell counts the data actually produces: 0 for the null= header that matches no cell, 3 for the * default-null character.
Contributor
Author
|
Thanks @echoix, addressed both: restored the original stdin data (no injected -9999, so it checks min and max exactly as before) and kept the file content byte-identical including the trailing newline. Verified locally, both tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the r.in.ascii testsuite from gunittest to pytest, continuing the one-at-a-time migrations from #7635/#7675.
Both tests use io.StringIO for input instead of stdin or an external file. The null-value test previously never included an actual null value in its data, so it only checked that the header parsed; it now injects two -9999 cells and asserts null_cells == 2. The default-null-character test keeps its original intent (a bare * marks a cell NULL) and its null_cells == 3 check.
Verified locally, both tests pass.