Skip to content

Org: Warn if overlaps occur in availability periods in add / edit. - #2597

Merged
cyrillkuettel merged 2 commits into
masterfrom
ogc-2602-uberschneidungen-bei-verfugbarkeitsraumen
Jul 30, 2026
Merged

cyrillkuettel merged 2 commits into
masterfrom
ogc-2602-uberschneidungen-bei-verfugbarkeitsraumen

Conversation

@cyrillkuettel

@cyrillkuettel cyrillkuettel commented Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.

Commit message

Org: Warn if overlaps occur in availability periods in add / edit.

TYPE: Feature
LINK: OGC-2602

Checklist

  • I have performed a self-review of my code

@linear

linear Bot commented Jul 23, 2026

Copy link
Copy Markdown

OGC-2602

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.50%. Comparing base (57c07b7) to head (35bbe7b).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/org/forms/allocation.py 95.01% <ø> (ø)
src/onegov/org/views/allocation.py 91.00% <100.00%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8e35e...35bbe7b. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cyrillkuettel cyrillkuettel changed the title Ogc 2602 uberschneidungen bei verfugbarkeitsraumen Org: Warn if overlaps occur in availability periods in add / edit. Jul 27, 2026
@cyrillkuettel
cyrillkuettel merged commit 88d62a2 into master Jul 30, 2026
16 checks passed
@cyrillkuettel
cyrillkuettel deleted the ogc-2602-uberschneidungen-bei-verfugbarkeitsraumen branch July 30, 2026 13:17
)
)

warn_about_skipped_allocations(request, form, new_allocations_count)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be new_allocations_count + updated_count

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that.

It seems also that warn_about_skipped_allocations would need to be remembered to be called by other views if they modify rules somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants