Repository navigation
The heap-growth test judges the median of its last rounds - #105
Merged
Merged
Conversation
…sy round cannot fail it Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ManyCalls_TheHeapDoesNotGrowruns each terminal for several rounds of 3000 calls and measures how much the managed heap grows in each round. It used to fail if the worst of the last three rounds grew by more than 64 KB.That test failed once, in Debug, in a full-suite run on a loaded machine. It passed in Release and in 21 isolated runs, so the failure was one noisy round, not a leak.
A real leak grows the heap in every round: a call that keeps one 24-byte object adds about 72 KB per round, so the median of the last rounds exceeds 64 KB and the test still fails. One noisy round can no longer fail it.
Test-only change: the test code and the comment on the limit.
Checks (full gate): Release and Debug builds 0 warnings, 0 errors; 9243 of 9243 tests pass in Release and in Debug; 86 of 86 sample checks pass; style and analyzers at info severity 0 findings in all 9 projects; DocFX 0 warnings, 0 errors.
🤖 Generated with Claude Code