Repository navigation
Dispose with ConfigureAwait(false) in the procedure-name queries; pin Pkcs in the benchmarks - #108
Merged
Merged
Conversation
… their command and reader with ConfigureAwait(false), like every other await in the library. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…, so Microsoft.Data.SqlClient no longer brings in the vulnerable 9.0.18. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The procedure-name query in
Source/SqlClient/ExpressiveSqlCommand.csandSource/MSSqlClient/ExpressiveSqlCommand.csusedawait usingon the command and reader, which awaitsDisposeAsyncwithoutConfigureAwait(false). They now useawait using var commandDisposal = command.ConfigureAwait(false);and the same for the reader, the form the rest of these packages use. Disposal order is unchanged (reader before command). No otherawait usinginSourcelacked it.The benchmarks project references Microsoft.Data.SqlClient 7.1.1, which brings System.Security.Cryptography.Pkcs 9.0.18 (NU1902/NU1903, GHSA-846f-f764-76mx and GHSA-2fmv-rv2c-59x7). It now pins 10.0.14, as
Source/MSSqlClientalready does. The benchmarks are not shipped.Checks
dotnet formatstyle and analyzers at info severity, all 9 projects: 0 findings.dotnet list package --vulnerable --include-transitiveon the benchmarks project: no vulnerable packages.🤖 Generated with Claude Code