Repository navigation
CI: the vulnerable-packages check also scans the benchmark project - #141
Merged
Merged
Conversation
The step listed only the Source projects and the core test project, so packages added under Benchmarks/ (Dapper.AOT, FastExpressionCompiler) were never checked. It now adds every project under Benchmarks/; the detection logic is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vulnerable-packages job in
tests.ymllisted only theSource/projects and the core test project. Packages that live only in the benchmark project (Dapper.AOT 1.1.0, FastExpressionCompiler 6.0.0, BenchmarkDotNet) were never checked.The step now also adds every project under
Benchmarks/. The detection logic (non-zero exit, "has the following vulnerable packages", NU1900) is unchanged.Checked locally: the edited step's script, run as-is against this branch, lists 8 projects (7 before) and reports no vulnerable packages, exit code 0.
🤖 Generated with Claude Code