Skip to content

CI: the vulnerable-packages check also scans the benchmark project - #141

Merged
electricessence merged 1 commit into
masterfrom
ci/vuln-scan-benchmarks
Nov 15, 2026
Merged

electricessence merged 1 commit into
masterfrom
ci/vuln-scan-benchmarks

Conversation

@electricessence

Copy link
Copy Markdown
Collaborator

The vulnerable-packages job in tests.yml listed only the Source/ projects and the core test project. Packages that live only in the benchmark project (Dapper.AOT 1.1.0, FastExpressionCompiler 6.0.0, BenchmarkDotNet) were never checked.

The step now also adds every project under Benchmarks/. The detection logic (non-zero exit, "has the following vulnerable packages", NU1900) is unchanged.

Checked locally: the edited step's script, run as-is against this branch, lists 8 projects (7 before) and reports no vulnerable packages, exit code 0.

🤖 Generated with Claude Code

The step listed only the Source projects and the core test project, so
packages added under Benchmarks/ (Dapper.AOT, FastExpressionCompiler) were
never checked. It now adds every project under Benchmarks/; the detection
logic is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@electricessence
electricessence merged commit f29d5c4 into master Nov 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant