Repository navigation
Benchmarks: Dapper.AOT variant on the real providers, and no per-call stamps on the benchmark path - #142
Merged
Conversation
RealProviderDapperAot.V7a is the V7 call (buffered Query<SynRow>(sql).AsList()) in its own class carrying [DapperAot]; one call site serves SQL Server and SQLite because the interceptor takes the IDbConnection it is given. V7 stays on plain Dapper. V7a_Sync is a benchmark next to V7_Sync; --verify-rp checks it against the oracle (every benchmark method) and against V2. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The timing wrapper stamped every Read, getter and IsDBNull (two timestamps each), which skews paths that make different numbers of wrapped calls per row. TimedConnection takes a TimedReaderMode: PerCallStamps (the default, used by the IN6 and S4 probes, unchanged) or ReaderOpenOnly (OpenCloseTimedReader: plain forwards, only the open and close of the reader are stamped, as in the Cut B build). The real-provider benchmark cases use ReaderOpenOnly. --verify-rp checks that the benchmark path's per-call counters stay at zero while the open/close stamps are recorded, and that a default wrapper still stamps. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
A Dapper.AOT variant (V7a) in the real-provider benchmarks, next to plain Dapper (V7), so ODX's mapping paths can be compared with source-generated Dapper on SQL Server and SQLite. Benchmarks/ only: no change to
Source/, tests, docs or build props.RealProviderDapperAot.cs: the one class that carries[DapperAot](Dapper.AOT 1.1.0 is already referenced by the project).V7ais the same call asV7(a bufferedQuery<SynRow>(sql).AsList()), run through the same timing path as the other variants. One intercepted call site serves both providers.RealProviderBenchmarks.cs: theV7a_Syncbenchmark;RealProviderChecks.cs:--verify-rpalso checks V7a against the oracle and against V2;RealProviderVariants.cs: a comment.Readand getter call (a per-call stamping reader skewed rows with different numbers of wrapped calls per row). ATimedReaderModeenum selects between per-call stamps (the IN6 and S4 probes, unchanged) and a reader-open-only reader (plain forwards, as before);--verify-rpchecks that the benchmark path records no per-call stamps.Checks
--verify-rppasses (374 checks, both target frameworks, SQLite and SQL Server LocalDB, widths 5 and 20, rows 1, 100 and 10,000); a deliberate corruption of V7a fails it.🤖 Generated with Claude Code