Repository navigation
Tests: count the channel rig's executes atomically - #167
Merged
Merged
Conversation
The every-rung channel test starts two feeds at once, so two readers can be created on different threads. The rig counted them with a plain increment, which can lose one: CI saw 4 of 5 on master. The count is now an Interlocked increment read with Volatile.Read. The library is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MappedToChannelReaderTests.EveryRung_DeliversTheRowsInOrder_AndCompletesfailed on master and on #161 with "Expected: 5, Actual: 4".The test starts two feeds at once (
startImmediately: true), so two readers can be created on different threads. The rig counted them with a plainExecutes++, which can lose an increment. The rows were right; only the test's count was off.The count is now
Interlocked.Increment, read withVolatile.Read. Tests only; the library is unchanged.Local check: the channel tests (580) ran 20 rounds in a row on net10.0 Release with no failure.
🤖 Generated with Claude Code