Repository navigation
11.0.0-rc.2: the version suffix, the README pin, a release-notes note and the public API baseline (the last of three stacked pull requests; the five packages pack and run on net472, net8, net9 and net10) - #86
Merged
Conversation
… and the public API baseline Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
11.0.0-rc.2: the version suffix, the README pin, a note in the release notes saying what rc.2 fixes, and the three new public overrides moved from unshipped to shipped; the five packages pack and run in a consumer on all four runtimes.
This is the last of three stacked pull requests: merge #84 (the consumer-feedback fixes), then #85 (stabilization), then this one, and delete each branch after merging it, so that the next pull request retargets to master (if a pull request still shows a branch as its base, it will merge into that branch, not into master: tell me and I rebase). It only moves the version. Eight changed lines in five files:
Source/Directory.Build.props:VersionSuffixrc.1torc.2(Release builds; Debug staysdebug).README.md: "Version 11 is a release candidate (11.0.0-rc.2)".docsite/articles/whats-new-11.md: the callout says11.0.0-rc.2and adds one sentence naming what rc.2 fixes for people who tried rc.1.Source/Core/PublicAPI.Shipped.txt/PublicAPI.Unshipped.txt: the threeoverridelines of the new procedure-name lookup move to shipped (sorted); unshipped is empty again.Verification (gentle: BelowNormal, 2 cores, from a clean package cache and a clean package folder)
On the tree of #84 plus #85 plus this change (the same tree you will have after merging all three):
11.0.0-rc.2with 0 warnings and 0 errors (Core 605 KB, Channel 115 KB, Dataflow 119 KB, MSSqlClient 96 KB, SqlClient 118 KB).required, the NULL rule, scalarnull, a pre-cancelled token,ToChannel,ToTargetBlock, both SQL Server adapters), and a C# 12 consumer passesAddParam("author", author).dotnet format0 findings, Roslynator 0, the sarif scan only the 7 documented leftovers: on the tree of the two pull requests below this one (the version change touches no code).For you
dotnet packalone fails with NU5026 on a clean tree: rundotnet build -c Releasefirst (the projects pack on build), then take the.nupkgfiles from eachbin\Release.🤖 Generated with Claude Code