Repository navigation
Output and input-output parameters now work through ExpressiveCommand and ExpressiveDbCommand - #88
Merged
Merged
Conversation
… and ExpressiveDbCommand The generic commands sent every parameter as an input, so a stored procedure with an output parameter failed with "expects parameter '@o', which was not supplied". The direction given to AddParam is now copied to the provider's parameter, as the SQL Server commands already did. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic commands sent every parameter as an input. A stored procedure with an output parameter failed with "expects parameter '@o', which was not supplied", and a return value or input-output value was never read back. Only the SQL Server commands passed the direction on.
ExpressiveCommandandExpressiveDbCommandnow copy the direction given toAddParam/AddReturnParamto the provider's parameter (one line in eachAddParamsoverride). No public API change.See it in
ParameterDirectionTests: all four directions reach the provider's parameter on both commands, a mixed call (input, output, input-output, return value) keeps each direction, a NULL-valued output parameter still arrives, and a parameter named from its argument stays an input.Verified: Release and Debug 0 warnings, 0 errors; 8,737 tests pass in both (the new file adds 7), 86 sample checks, DocFX 0 warnings, style and analyzers 0 findings.
🤖 Generated with Claude Code