Repository navigation
A text command's AddParam(value) and AddParams(object) use the @name markers in its SQL - #92
Merged
Merged
Conversation
…m the @name markers in its SQL text Previously a text command sent each argument under the name it was written with, even when the SQL declared a different parameter. The SQL text is now scanned for @name markers (not those inside strings, quoted identifiers or comments, and not @@System variables) and arguments are matched to them the way stored procedure parameters are. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a text command the library sent each argument under the name written in code, even when the SQL declared a different parameter (for example
@company_serial_numforCompanySerialNum), so the value never reached the query.The SQL text is now scanned for
@namemarkers, skipping strings, quoted identifiers, comments and@@systemvariables. Arguments are matched to them the way stored procedure parameter names already are. A text command with no marker keeps the old behaviour.See it in the tests:
SqlTextParametersTests(the scanner),SqlTextDerivedNamesTests(commands) and the six updated cases inDerivedParameterNameTests.Verified: 8844 tests pass in Release and Debug, 0 build warnings, 86 sample checks, style and analyzers 0 findings.
🤖 Generated with Claude Code