Skip to content

test(python-flask): fix the stale assertion and re-enable testControllerTestModelExampleUsesImportedName #25552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 1 commit into from
Nov 4, 2026
Merged

test(python-flask): fix the stale assertion and re-enable testControllerTestModelExampleUsesImportedName #25552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .../src/test/java/org/openapitools/codegen/python/PythonFlaskConnexionServerCodegenTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ public void testDefaultController() throws IOException {
"Untagged operations should honor defaultController, not fall back to default_controller.py");
}

@Test(description = "model examples in generated controller tests use the imported class name, not the package", enabled = false)
@Test(description = "model examples in generated controller tests use the imported class name, not the package")
public void testControllerTestModelExampleUsesImportedName() throws IOException {
final DefaultCodegen codegen = new PythonFlaskConnexionServerCodegen();
final String outputPath = generateFiles(codegen, "src/test/resources/3_0/python-flask/model-typed-params.yaml");
Expand All @@ -176,11 +176,13 @@ public void testControllerTestModelExampleUsesImportedName() throws IOException
assertFileContains(controllerTest,
"from openapi_server.models.filter import Filter",
"from openapi_server.models.trace import Trace",
"query_string = [('filter', Filter()),",
// a model-typed query parameter is sent as form/explode wire pairs, not a Filter() repr
"query_string = [('name', 'name_example'),",
"('filters', [Filter()]),",
"('filterMap', {'key': Filter()}),",
"filter = Filter()",
": Trace(),");
"filter_ = Filter()",
// a model-typed header is sent as its simple-style wire value, not a Trace() repr
"'X-Trace': 'id,id_example',");
// User-supplied examples that merely look like a constructor are kept verbatim.
assertFileContains(controllerTest, "('label', 'openapi_server.Filter()')", "('count', openapi_server.int())");
// A model-typed parameter with a default keeps the default as its example.
Expand Down
Loading