DEP: allow running python helper scripts with any Python 3.12.x patch version#410
DEP: allow running python helper scripts with any Python 3.12.x patch version#410neutrinoceros wants to merge 1 commit into
Conversation
|
validated at astropy/astropy#20122 |
|
unrelated linting issues are addressed at #411 |
|
Alternatively, we could also pin the version installed through |
|
this started failing for us as well yesterday afternoon, good to know there's a fix. Are we concerned about the virtualenv tox tests failing? |
zacharyburnett
left a comment
There was a problem hiding this comment.
if the tests pass this should be good
|
I think the remaining failures are part stylistic (#411) and part due to a an unpinned version of coverage. I can probably address the latter in another PR too |
|
I couldn't figure out the coverage issue yet. It's definitely unrelated though. I suggest merging and releasing what's already fixed if possible. |
|
@braingram brought up a good point, shouldn't this patch version specifier be the docs at https://packaging.python.org/en/latest/specifications/version-specifiers/#compatible-release suggest that |
|
Thank you ! In that case I think I'd rather pin Python itself |
|
... though I would also need to change these lines, in a similar way, so scratch that |
f1843c7 to
f0ea02c
Compare
|
and to avoid any confusion around the meaning of |
f0ea02c to
09bee04
Compare
don't worry, I also thought it worked like that until brett brought it up lol |
pinning 3.12 exactly leads to issues with the latest versions of
pipx, presumably since version 1.15.1 (ubuntu-latestcurrently ships 1.16.0)close #409
xref: pypa/pipx#1953