Conversation
Points the prop submodule at the multi-interface mDNS responder (OpenBikeControl/prop#7): announce per reachable interface, each carrying that interface's own address, so a multi-homed host (e.g. Ethernet + Wi-Fi, even same /24) is reachable on every LAN it is on. Fixes the quantified "advertisedAddress warn / found-but-can't-connect" class of discovery failures. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the
propsubmodule to the per-interface mDNS responder.Depends on
OpenBikeControl/prop#7 — kept as a draft until that merges. If prop#7 is squash-merged (new SHA), this pointer will be updated to the merged commit before marking ready. Merging this before prop#7 would point 6.6 at a feature-branch commit, so: do not merge yet.
Why
On a multi-homed host (Ethernet + Wi-Fi, even on the same /24) BikeControl advertised a single address and pinned egress to one interface, so a trainer app on the other interface found it but couldn't connect. Quantified: 21 submitted self-tests flagged
advertisedAddresswarn. prop#7 announces once per reachable interface, each packet carrying that interface's own address — no single packet ever lists an unreachable address (avoiding the .NET/Mono "No route to host" hazard).🤖 Generated with Claude Code