Skip to content

fix(records): the licence offer and a held PDF's title stay whole on a phone at large text - #929

Merged
sickerine merged 2 commits into
mainfrom
fix/licence-offer-and-held-card
Nov 22, 2026
Merged

sickerine merged 2 commits into
mainfrom
fix/licence-offer-and-held-card

Conversation

@sickerine

Copy link
Copy Markdown
Collaborator

Found by the daily QA of 22 November, checking #926 and #928 on Admin QA 8 October 2026.

Problem

Change

  • The offer keeps to half the row, and its label wraps there instead of being cut. A label that fits on one line keeps the button's usual height.
  • The held-PDF card's title is one size smaller (text-base for text-lg) only while its words sit under the page picture: a card under 12rem, on a phone at 150% text or more. From sm up, and at normal text on a phone, it is text-lg as before.

Checks

On the verify stack (one record embargoed to 20 November 2027, and a new Report draft with "All rights reserved." under CC BY 4.0), this branch against main:

main this branch
Held-PDF title, 320 at 200% (Chromium, Firefox, WebKit) 36px, "November" broken 32px, every word whole
Held-PDF title, 360 at 200% 36px 32px, whole
Held-PDF title, 390 at 100%, 1440 at 200% 18px and 36px, beside the same
Offer, 390 at 200% (Chromium) "Us…", 110px beside the note under the note, 220px, whole
Offer, 320 at 200% cut under the note, whole
Offer, 1440 and 390 at 100% 146x36, whole the same
  • The first version only let the label wrap inside its half of the row. At 390 and 200% that broke "Other" inside the word in a 62px column, so on a phone at large text (under 14rem of field; a phone's field is 20rem at normal text) the offer now goes under the note. From sm up it stays beside the note at any text size.
  • The longest month word in the card's 12 languages ("septiembre", 187px at 32px) fits the 190px column at 320 and 200%.
  • WebKit's admin doesn't sign in on the local stack, so Safari's inspector at 1440 gets checked on Admin QA after the release.
  • npx tsc --noEmit, eslint on both files, npm run check:ui-rules, npm run quality:fallow -- --base origin/main.
  • Reviewed by GPT-6.1 Sol: no findings on these two changes.

@coderabbitai

coderabbitai Bot commented Nov 22, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9e426901-f7bd-4747-9e34-26eaed7f0941
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 22, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-22T09:03:23.724460Z b48ec1d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sickerine
sickerine merged commit 238e938 into main Nov 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant