Repository navigation
fix(records): the licence offer and a held PDF's title stay whole on a phone at large text - #929
Merged
Merged
Conversation
…d PDF's title fits a phone at large text
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the daily QA of 22 November, checking #926 and #928 on Admin QA 8 October 2026.
Problem
Change
text-basefortext-lg) only while its words sit under the page picture: a card under 12rem, on a phone at 150% text or more. Fromsmup, and at normal text on a phone, it istext-lgas before.Checks
On the verify stack (one record embargoed to 20 November 2027, and a new Report draft with "All rights reserved." under CC BY 4.0), this branch against main:
smup it stays beside the note at any text size.npx tsc --noEmit, eslint on both files,npm run check:ui-rules,npm run quality:fallow -- --base origin/main.