Skip to content

feat(upload): add optional force-overwrite before upload - #197

Open
PIKACHUIM wants to merge 1 commit into
mainfrom
feat/upload-force-overwrite
Open

PIKACHUIM wants to merge 1 commit into
mainfrom
feat/upload-force-overwrite

Conversation

@PIKACHUIM

Copy link
Copy Markdown
Member

tence check and, when the file exists, one extra delete request per upload.

Summary / 摘要

Drivers without overwrite semantics (Aliyun Drive via WebDAV, issue #100) silently create xxx_(1).ext copies instead of replacing the file.

Add a global setting upload_force_overwrite (default off). When enabled, every upload first checks whether the target exists and deletes it, then writes:

  • /fs/put and /fs/form delete after the body has passed the size limit, so a rejected upload never destroys the existing file.
  • /fs/multipart/init only cleans up when a new session is created; resumed sessions are left alone.
  • WebDAV PUT and S3 PutObject follow the same order.
  • /fs/get_direct_upload_info deletes before signing the direct upload URL, but an explicit Overwrite: false header still wins.

Directories are never deleted (uploading a file over a folder now fails with a readable error). Delete errors that mean "already gone" are ignored; other delete failures abort the upload instead of silently producing a copy.

The setting's help text states that it costs one exis

  • This PR has breaking changes.
    / 此 PR 包含破坏性变更。
  • This PR changes public API, config, storage format, or migration behavior.
    / 此 PR 修改了公开 API、配置、存储格式或迁移行为。
  • This PR requires corresponding changes in related repositories.
    / 此 PR 需要关联仓库同步修改。

Related repository PRs / 关联仓库 PR:

  • OpenList:
  • OpenList-Docs:

Related Issues / 关联 Issue

Testing / 测试

  • go test ./...
  • Manual test / 手动测试:

Checklist / 检查清单

  • I have read CONTRIBUTING.
    / 我已阅读 CONTRIBUTING。
  • I confirm this contribution follows the repository license, contribution policy, and code of conduct.
    / 我确认此贡献符合仓库许可证、贡献规范和行为准则。
  • I have formatted the changed code with gofmt, go fmt, or prettier where applicable.
    / 我已按适用情况使用 gofmt、go fmt 或 prettier 格式化变更代码。
  • I have requested review from relevant maintainers or code owners where applicable.
    / 我已在适用情况下请求相关维护者或代码所有者审查。

AI Disclosure / AI 使用声明

  • This PR includes AI-assisted content.
    / 此 PR 包含 AI 辅助内容。

Tools used / 使用工具:

  • ChatGPT
  • Codex
  • GitHub Copilot
  • Claude
  • Gemini
  • Other (please specify) / 其他(请注明):

Usage scope / 使用范围:

  • Code generation / 代码生成

  • Refactoring / 重构

  • Documentation / 文档

  • Tests / 测试

  • Translation / 翻译

  • Review assistance / 审查辅助

  • I have reviewed and validated all AI-assisted content included in this PR.
    / 我已审核并验证此 PR 中的所有 AI 辅助内容。

  • I have ensured that all AI-assisted commits include Co-Authored-By attribution.
    / 我已确保所有 AI 辅助提交都包含 Co-Authored-By 归属信息。

  • I can reproduce all AI-assisted content included in this PR without any AI tools.
    / 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。

Drivers without overwrite semantics (Aliyun Drive via WebDAV, issue #100)
silently create `xxx_(1).ext` copies instead of replacing the file.

Add a global setting `upload_force_overwrite` (default off). When enabled,
every upload first checks whether the target exists and deletes it, then
writes:

- /fs/put and /fs/form delete after the body has passed the size limit, so a
  rejected upload never destroys the existing file.
- /fs/multipart/init only cleans up when a new session is created; resumed
  sessions are left alone.
- WebDAV PUT and S3 PutObject follow the same order.
- /fs/get_direct_upload_info deletes before signing the direct upload URL, but
  an explicit `Overwrite: false` header still wins.

Directories are never deleted (uploading a file over a folder now fails with
a readable error). Delete errors that mean "already gone" are ignored; other
delete failures abort the upload instead of silently producing a copy.

The setting's help text states that it costs one existence check and, when the
file exists, one extra delete request per upload.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
openlist-work 9fd81e5 Commit Preview URL

Branch Preview URL
Nov 10 2026, 01:01 PM

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
openlist-tsworkers 9fd81e5 Nov 10 2026, 01:00 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cloudflare Workers部署,阿里云盘WebDAV上传无法覆盖文件,生成 xxx_(n) 格式副本

1 participant