Sign the commits the SDK bump workflow pushes - #106
Merged
Conversation
`main` requires signed commits, so every bump the workflow opened was blocked on merge: the runner has no signing key, and a plain `git commit` as `github-actions[bot]` cannot produce one. The commit is now created through the `createCommitOnBranch` GraphQL mutation, which GitHub signs itself with the job's `GITHUB_TOKEN`. That needs no key or secret, and still attributes the commit to the bot. `HUSKY: "0"` guarded a `git commit` that no longer runs, so it goes too. Claude-Session: https://claude.ai/code/session_01RuhGJYRA4xYosiqnKv7qpB
MahmoudElsayad
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainrequires signed commits. The bump workflow committed with a plaingit commitasgithub-actions[bot], and a runner has no signing key — soevery automated bump PR arrived unmergeable. #105 was the first to hit it.
What changed
The bump commit is now created through the
createCommitOnBranchGraphQLmutation, which GitHub signs itself using the job's
GITHUB_TOKEN. No key, nosecret, and the commit is still attributed to the bot.
HUSKY: "0"guarded agit committhat no longer runs, so it goes too.Verification
The new script produced the commit now on #105 (
ec0cc45): tree identical tothe bot's original
1db9719, andverification.verified: true/reason: "valid"from the API. That PR went fromBLOCKEDto mergeable.https://claude.ai/code/session_01RuhGJYRA4xYosiqnKv7qpB