Repository navigation
Document the ILoggerFactory registration guarantee - #7982
Merged
Merged
Conversation
danielmarbach
force-pushed
the
docs-logging-factory-guarantee
branch
from
October 14, 2026 10:36
0335249 to
7a706ca
Compare
Contributor
|
With those additions, our internal guidelines can be deleted, I think. |
danielmarbach
approved these changes
Oct 14, 2026
andreasohlund
enabled auto-merge (squash)
October 14, 2026 10:42
andreasohlund
disabled auto-merge
October 14, 2026 10:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
docs/logging.md, a design page that documents a guarantee other repositories rely on: since 10.2, every endpoint's service collection contains aMicrosoft.Extensions.Logging.ILoggerFactory. Transports and other components can link to this page instead of to the pull requests that introduced the behavior.The page covers:
EndpointCreator.Configure, on the root service collection, throughAddLoggingwithTryAddsemantics) and that Core resolves the factory withGetRequiredService.LogManager.UseFactorypath.docs/README.mdlinks the page under "Architecture and design".The page is a design page and not an ADR because the public records (#7659, #7633, #7661, #7758) do not record the alternatives that were rejected. Internal context was consulted and is not quoted.
Verification: the statements were checked against the current code in
EndpointCreator,EndpointPreparation,ReceiveComponent,LogManager,HostSettings, andKeyedServiceProviderAdapter.