Skip to content

Disable RavenDB storage prefetching by default #5832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ramonsmits wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Disable RavenDB storage prefetching by default #5832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/ServiceControl.RavenDB/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ USER ravendb

ENV RAVEN_License_Eula_Accepted=true \
RAVEN_License_Path=/usr/lib/ravendb/servicecontrol-license.json \
RAVEN_Setup_Mode=None
RAVEN_Setup_Mode=None \
RAVEN_Storage_EnablePrefetching=false

LABEL org.opencontainers.image.source=https://github.com/Particular/ServiceControl \
org.opencontainers.image.authors="Particular Software" \
Expand Down
3 changes: 3 additions & 0 deletions src/ServiceControl.RavenDB/EmbeddedDatabase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ public static EmbeddedDatabase Start(EmbeddedDatabaseConfiguration databaseConfi
// HINT: If this is not set, then Raven will pick a default location relative to the server binaries
// See https://github.com/ravendb/ravendb/issues/15694
$"--Indexing.NuGetPackagesPath=\"{nugetPackagesPath}\"",
// HINT: Storage.EnablePrefetching is server-wide only and defaults to true in RavenDB. ServiceControl
// disables it by default. Set RAVEN_Storage_EnablePrefetching on the container image to change it there.
"--Storage.EnablePrefetching=false",
..optionalArgs
],
DataDirectory = databaseConfiguration.DbPath,
Expand Down
Loading